react icon indicating copy to clipboard operation
react copied to clipboard

Published 20 hours ago • verified publisher icon primer

Add `aria-expanded` back to `AnchoredOverlay`

Open TylerJDev opened this issue 10 months ago • 3 comments

Will resolve: https://github.com/github/accessibility-audits/issues/6932

We have an open accessibility issue related to how we handle aria-expanded within AnchoredOverlay. We did not apply aria-expanded when a menu was open since it was redundant, and it was very unlikely that there'd be navigation outside of the menu before it was closed. We've received feedback that this may cause an unintended effect for users using specific devices/AT that makes it difficult to leave the menu.

Changelog

Changed

  • Adds full aria-expanded state to AnchoredOverlay.

Rollout strategy

Integration test PR: https://github.com/github/github/pull/323711. There are some flakey tests that are failing which are not caused by this PR. The changes required for this PR are: https://github.com/github/github/pull/323711/commits/dd6a1dee058ee4659bb1ed36ac50e5356b3de832

  • [x] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [x] Tested in Chrome
  • [x] Tested in Firefox
  • [x] Tested in Safari
  • [x] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

TylerJDev avatar Apr 02 '24 15:04 TylerJDev

🦋 Changeset detected

Latest commit: 4b4e4ff265786f25f6c015bec7f1db9f39792948

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 02 '24 15:04 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.6 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js 88.88 KB (+0.05% 🔺)

github-actions[bot] avatar Apr 02 '24 15:04 github-actions[bot]

@TylerJDev Hi! Do you have an idea of when this will be merged? 🙏🏻

lindseywild avatar May 16 '24 13:05 lindseywild

@lindseywild, just needs to get reviewed now! I redid my integration test PR, and it looks good (outside of flakey tests). Requires some changes in GH for tests: https://github.com/github/github/pull/323711#issuecomment-2098990100.

cc: @primer/engineer-reviewers for a review :eyes:

TylerJDev avatar May 22 '24 15:05 TylerJDev

@primer/engineer-reviewers Can someone please review this when you get a chance? Thanks!

lindseywild avatar May 28 '24 20:05 lindseywild