Tim Hutt

Switch to CMake

5

I think we should switch from Make to CMake. This would have a number of benefits: 1. We can easily make the arch part of the targets instead of a...

Install Sail from binary in CI

6

This should be a lot faster. It also means the version is pinned properly which wasn't the case before. I also recommended users to do the same in the README...

Duplicate vector CSR code

1

The code for reading/writing vector CSRs is duplicated [here](https://github.com/riscv/sail-riscv/blob/31f809346e1020d191b46d519ad6435e2428be39/model/riscv_insts_zicsr.sail#L66) and [here](https://github.com/riscv/sail-riscv/blob/31f809346e1020d191b46d519ad6435e2428be39/model/riscv_vext_control.sail#L18). The latter is not used because the former takes priority. The code is not actually the same, so something...

Audit usage of `var` and `undefined`

1

There are many uses of `var` and `undefined` that are unnecessary and dodgy, especially in the vector code. For example this: ``` var result : vector('n, dec, bits('o)) = undefined;...

Replace undefined with vector_init in vector code

1

There's a few places in the vector code like this: ``` val init_masked_result : forall 'n 'm 'p, 'n >= 0. (int('n), int('m), int('p), vector('n, dec, bits('m)), vector('n, dec, bool))...

Suppose you have a very large JSON file containing a load of logs (strings). I want to transform them into another format, but I don't want to load all the...

Crash loading STL file

4

Using the Windows binary download from Sourceforge, compiled on Feb 7 2024, I opened this STL file: [bar.zip](https://github.com/user-attachments/files/16936512/bar.zip) Elmer then crashes. By the way the UX of loading meshes is...

Move the binaries to Github

3

Sourceforge is pretty sketchy and screams "ancient & unmaintained". Imagine my surprise after downloading the binaries from there that Elmer is actually very actively maintained and the source is on...

CMake support doesn't work with generated code

7

The CMake support you've added is great but unfortunately I think it is done in a way that makes it basically impossible to use with any generated code (which is...

CompilationDatabase setting is confusing

2

I don't really know what to say here but clangd just seems to not even attempt loading `compile_commands.json`. Here's my `/home/me/workspace/project/.clangd` file (which it *does* read): ``` CompileFlags: CompilationDatabase: "/home/me/workspace/projects/path/to/compile_commands.json"...