sail-riscv icon indicating copy to clipboard operation
sail-riscv copied to clipboard

Install Sail from binary in CI

Open Timmmm opened this issue 1 year ago • 6 comments
trafficstars

This should be a lot faster. It also means the version is pinned properly which wasn't the case before.

I also recommended users to do the same in the README do they don't have to deal with OPAM.

Timmmm avatar Aug 29 '24 15:08 Timmmm

A trick I use in the Sail CI to speed it up is to cache the ~/.opam directory: https://github.com/rems-project/sail/blob/sail2/.github/workflows/build.yml

Alasdair avatar Aug 29 '24 16:08 Alasdair

I'm hoping we can get away without OPAM as @jordancarlin suggested.

If this attempt doesn't work I'm writing a Dockerfile so I can try it locally! The edit-build-test cycle for Github CI is ridiculous.

Timmmm avatar Aug 29 '24 16:08 Timmmm

Well, the C side seemed to work, but the OCaml build fails because it can't find ocamlfind, and we use -use-ocamlfind.

Maybe I'll just finish #509 first.

Timmmm avatar Aug 29 '24 16:08 Timmmm

Test Results

396 tests  ±0   396 :white_check_mark: ±0   0s :stopwatch: ±0s   4 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 85e9522b. ± Comparison against base commit 0764b5ea.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 29 '24 16:08 github-actions[bot]

Well, the C side seemed to work, but the OCaml build fails because it can't find ocamlfind, and we use -use-ocamlfind.

Maybe I'll just finish #509 first.

That probably makes sense because otherwise it’s just unnecessary work that’ll be quickly obsolete. Or we just leave opam for now (assuming it has all the needed dependencies).

jordancarlin avatar Aug 29 '24 17:08 jordancarlin

I think this should be ready to go, the only thing I'm not sure about is the Coq stuff. It was last touched 4 years ago by @bacam - Brian do you remember this?

Timmmm avatar Sep 19 '24 09:09 Timmmm