Tim Lovell-Smith

Results 377 comments of Tim Lovell-Smith

> All the LintDiff validations related to DHSM existed before the current PR submission and I believe they resurfaced because of changing the DedicatedHsmName.name from "name" to "dedicatedHsmName" parameter This...

What is it exactly, that you're maintaining API compatibility with, for the error response format, when you add NEW apis? Is this just about having one error response type across...

>❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model. Location: Microsoft.HardwareSecurityModules/stable/2024-06-30/cloudhsm.json#L778 You should really fix this, but maybe not in...

> > > ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model. > > > Location: Microsoft.HardwareSecurityModules/stable/2024-06-30/cloudhsm.json#L778 > > >...

> > What is it exactly, that you're maintaining API compatibility with, for the error response format, when you add NEW apis? Is this just about having one error response...

> > > > What is it exactly, that you're maintaining API compatibility with, for the error response format, when you add NEW apis? Is this just about having one...

Why do you have filter query parameters on the path >"/providers/Microsoft.Management/managementGroups/{managementGroupId}/subscriptions/{subscriptionId}/providers/Microsoft.Quota/groupQuotas/{groupQuotaName}/quotaAllocations/{resourceName}": {

> Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Quotas_UsagesRequest_ForNetworkLocation: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L143

Can you all fix the PR description before we merge this?

> > Can you all fix the PR description before we merge this? > > The current PR description is not correct, is it? This is a control Plane PR....