Tim Lovell-Smith
Tim Lovell-Smith
> /pr RequestMerge Blocked on GO SDK issues. Please address that, then request merge again
@akshitgoyal Please refactor by using references to the [new] common types NSP definitions, letting me know of any blockers https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/networksecurityperimeter.json
@akshitgoyal You can add a suppression, or copy/paste the parameter definition and define your own pattern as reusing the parameter definition isn't critical, its just a convenience.
@akshitgoyal Actually, is there a casing issue in your operation paths? It should be ''/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/networkSecurityPerimeterConfigurations/{networkSecurityPerimeterConfigurationNameParameter}'' with a little 'n' at the start of the the parameter name (camel case), instead...
/azp run
The remaining LintDiff warnings look benign to me in this case
Please fill in purpose of PR and due diligence sections
ModelValidation errors need fixing, would be great to get that done before further ARM review
> > ModelValidation errors need fixing, would be great to get that done before further ARM review > > Hi @TimLovellSmith , the ModelValidation errors are not related to this...
I didn't see any significant changes from ARM POV, which is good for a refactor, so I've signed off for ARM. but we still need to figure out what is...