Tim Lovell-Smith
Tim Lovell-Smith
I think having 'id' at the top level is the way to go but there might be something a bit 'off' with the way you are using x-ms-azure-resource actually. Just...
> }, POST operations shouldn't normally return resources. Do you really need to return these properties? Consider deprecating or removing them, if not. --- Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2977 in dafbb66. [](commit_id...
> "x-ms-azure-resource": true POST operations shouldn't normally return resources, so I'd remove this tag. Unless it is too breaking for SDK. --- Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2983 in dafbb66. [](commit_id = dafbb66d086ca156bd0b5f23e7a946dd2ce41431,...
> "description": "Resource ID.", What resource is it returning the ID of? a 'can migrate result' is not an azure resource. --- Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2969 in dafbb66. [](commit_id = dafbb66d086ca156bd0b5f23e7a946dd2ce41431,...
> "x-ms-azure-resource": true POST request bodies should not be marked as x-ms-azure-resource, except perhaps in the very UNusual case they're creating a new resource. I recommend removing this unless it...
> "x-ms-azure-resource": true this would be [ARMBlockingComment] but its not part of the proposed change: POST request bodies should not be marked as x-ms-azure-resource, except perhaps in the very UNusual...
> "x-ms-azure-resource": true this would be [ARMBlockingComment] if it were a new REST API but its not part of the proposed change: POST operations shouldn't normally return resources. Do you...
> "description": "Resource ID.", of? --- Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:3108 in dafbb66. [](commit_id = dafbb66d086ca156bd0b5f23e7a946dd2ce41431, deletion_comment = False)
> "x-ms-azure-resource": true I assume your Origins are modeled as resources... and then you should ideally inherit ProxyResource instead of using this tag. --- Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:5503 in dafbb66. [](commit_id...
> "x-ms-azure-resource": true Should be [ARMBlockingComment] were this a new API (but its not right) This tag shouldn't be on the 'properties' property bag! Please remove it! ... Unless its...