Tim Lovell-Smith

Results 377 comments of Tim Lovell-Smith

Also, could you please give me a quick rundown on the difference between doing POST setupExtension and using the existing API ```"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HybridCompute/machines/{machineName}/extensions/{extensionName}": { "put": { "tags": [ "MachineExtensions" ], "operationId":...

> "policyName" [ARMBlockingComment] you'll need to fix this too if you're changing it from policyName to name - model validation should catch this, but apparently doesn't?? /cc @rkmanda --- Refers...

> "RaiContentFilter": { This doesn't have the required 'resource' properties. The linter is probably complaining about that already. --- Refers to: specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/preview/2024-06-01-preview/cognitiveservices.json:6398 in 22e9697. [](commit_id = 22e96971d2becabb6272eb154584bc2b016c9d7c, deletion_comment = False)

Still needs BreakingChange-JavaScript-Sdk-Suppression-Approved

@FumingZhang Cool. Just one question about that: Is it a good idea having none by default? Wouldn't being "secure by default" be a better idea?

Looks like #2948 should fix this for the case where T=Octokit.PullRequestReviewComment.

Please fix the spellCheck failures by using the appropriate camelCase or PascalCase naming styles in each context, and/or using the common-types LocationParameter definition.