Tim Lovell-Smith

Results 377 comments of Tim Lovell-Smith

My 2c: 'empty content' is just different from 'no content'. 204 is for 'no content' only, not empty.

@mgravell I got another query about this issue and it seems like the issue is basically that lock contention spikes up when there is high load on the system, and...

@ambrahma - while you're in refactoring mode, I'd suggest you to take full advantage of common-types and not declare those yourself, that's also going to be quite helpful for reducing...

@suhasrao My feedback has been addressed, but could you please take a look at signoff? Hopefully there are few remaining issues, but I think it'd be good to have more...

@tianxchen-ms Looks to me like one of the breaking change errors is caused by an actual bugfix in PrivateDnsZone.json - the old definition of CloudError (used as the error response)...

Note, I don't know if we already had a reasonably good precedent established here, but if we didn't, I'm proposing that 'no spaces' is the recommended style: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v3/managedidentity.json

The contribution checklist for this draft PR is not yet complete. When the draft is ready, please complete it, remove the ARMChangesRequested label, and send email to the current ARM...

> "description": "Ok and the operation will complete synchronously.", isn't it completed already? --- Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/cdn.json:481 in fa36b8a. [](commit_id = fa36b8a8545c01cb44145b9855a89c9b7428b5c7, deletion_comment = False)

> } Why would 200 need location header? Normally only 202 does. --- Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/cdn.json:486 in fa36b8a. [](commit_id = fa36b8a8545c01cb44145b9855a89c9b7428b5c7, deletion_comment = False)

> "description": "Ok and the operation will complete synchronously.", OK / Okay --- Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/cdn.json:481 in fa36b8a. [](commit_id = fa36b8a8545c01cb44145b9855a89c9b7428b5c7, deletion_comment = False)