Tim Lovell-Smith
Tim Lovell-Smith
@konrad-jamrozik Who does versioning review?
> > @JeffreyRichter Do you think this contribution is okay as is, as a breaking change bugfix? > > If the service versions actually supported this over the wire but...
@akshitgoyal Please refactor by using references to the [new] common types NSP definitions, letting me know of any blockers https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/networksecurityperimeter.json
> had to add parameter definition for NetworkSecurityPerimeterConfigurationNameParameter because the current common types don't have a "pattern" restriction Thats fine for now thanks!
@jorgecotillo if I want to see just the changes between old and new api versions, what commits should I be diffing here?
We can fix the ErrorResponse warnings from old common types in the next version, I guess.
Lets indeed remove the force delete parameter if having it has no benefit.
> }, nit - I think systemData is already inherited from v5 trackedResource by default, so you should be able to omit this --- Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5456 in d04b278. [](commit_id...
> "tags": { tags are already inherited from v5 trackedResource by default, so you should be able to omit this --- Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5473 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment...