azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Add NSP API to workspaces

Open akshitgoyal opened this issue 1 year ago • 6 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

akshitgoyal avatar Apr 17 '24 23:04 akshitgoyal

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for JavaScript (label: BreakingChange-JavaScript-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 13 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-04 package-2024-04(26b76ab) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
:warning: MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L37
RPC-Get-V1-11
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L46
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L52
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L55
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L68
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L91
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L97
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L100
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L116
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L136
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L142
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L145
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L163
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
:warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/operationalinsights/resource-manager/readme.md
tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2024-04
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed in generating from 2a809539d15a4e69fd6c2c6b83fde59006344535. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • Azure.ResourceManager.OperationalInsights [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 2a809539d15a4e69fd6c2c6b83fde59006344535. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/operationalinsights/armoperationalinsights [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `Cluster.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    info	[Changelog] - Type of `ClusterPatch.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    info	[Changelog] - Operation `*TablesClient.Update` has been changed to LRO, use `*TablesClient.BeginUpdate` instead.
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `CapacityFiftyThousand`, `CapacityFourHundred`, `CapacityOneHundred`, `CapacityTenThousand`, `CapacityThreeHundred`, `CapacityTwentyFiveThousand`, `CapacityTwoHundred` added to enum type `Capacity`
    info	[Changelog] - New value `CapacityReservationLevelFiftyThousand`, `CapacityReservationLevelTenThousand`, `CapacityReservationLevelTwentyFiveThousand` added to enum type `CapacityReservationLevel`
    info	[Changelog] - New value `DataSourceTypeIngestion` added to enum type `DataSourceType`
    info	[Changelog] - New value `IdentityTypeApplication`, `IdentityTypeKey`, `IdentityTypeManagedIdentity`, `IdentityTypeUser` added to enum type `IdentityType`
    info	[Changelog] - New enum type `AccessRuleDirection` with values `AccessRuleDirectionInbound`, `AccessRuleDirectionOutbound`
    info	[Changelog] - New enum type `ColumnDataTypeHintEnum` with values `ColumnDataTypeHintEnumArmPath`, `ColumnDataTypeHintEnumGUID`, `ColumnDataTypeHintEnumIP`, `ColumnDataTypeHintEnumURI`
    info	[Changelog] - New enum type `ColumnTypeEnum` with values `ColumnTypeEnumBoolean`, `ColumnTypeEnumDateTime`, `ColumnTypeEnumDynamic`, `ColumnTypeEnumGUID`, `ColumnTypeEnumInt`, `ColumnTypeEnumLong`, `ColumnTypeEnumReal`, `ColumnTypeEnumString`
    info	[Changelog] - New enum type `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
    info	[Changelog] - New enum type `IssueType` with values `IssueTypeConfigurationPropagationFailure`, `IssueTypeMissingIdentityConfiguration`, `IssueTypeMissingPerimeterConfiguration`, `IssueTypeUnknown`
    info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
    info	[Changelog] - New enum type `NetworkSecurityPerimeterConfigurationProvisioningState` with values `NetworkSecurityPerimeterConfigurationProvisioningStateAccepted`, `NetworkSecurityPerimeterConfigurationProvisioningStateCanceled`, `NetworkSecurityPerimeterConfigurationProvisioningStateCreating`, `NetworkSecurityPerimeterConfigurationProvisioningStateDeleting`, `NetworkSecurityPerimeterConfigurationProvisioningStateFailed`, `NetworkSecurityPerimeterConfigurationProvisioningStateSucceeded`, `NetworkSecurityPerimeterConfigurationProvisioningStateUpdating`
    info	[Changelog] - New enum type `ProvisioningStateEnum` with values `ProvisioningStateEnumDeleting`, `ProvisioningStateEnumInProgress`, `ProvisioningStateEnumSucceeded`, `ProvisioningStateEnumUpdating`
    info	[Changelog] - New enum type `ResourceAssociationAccessMode` with values `ResourceAssociationAccessModeAudit`, `ResourceAssociationAccessModeEnforced`, `ResourceAssociationAccessModeLearning`
    info	[Changelog] - New enum type `Severity` with values `SeverityError`, `SeverityWarning`
    info	[Changelog] - New enum type `SourceEnum` with values `SourceEnumCustomer`, `SourceEnumMicrosoft`
    info	[Changelog] - New enum type `TablePlanEnum` with values `TablePlanEnumAnalytics`, `TablePlanEnumBasic`
    info	[Changelog] - New enum type `TableSubTypeEnum` with values `TableSubTypeEnumAny`, `TableSubTypeEnumClassic`, `TableSubTypeEnumDataCollectionRuleBased`
    info	[Changelog] - New enum type `TableTypeEnum` with values `TableTypeEnumCustomLog`, `TableTypeEnumMicrosoft`, `TableTypeEnumRestoredLogs`, `TableTypeEnumSearchResults`
    info	[Changelog] - New function `*ClientFactory.NewQueriesClient() *QueriesClient`
    info	[Changelog] - New function `*ClientFactory.NewQueryPacksClient() *QueryPacksClient`
    info	[Changelog] - New function `NewQueriesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QueriesClient, error)`
    info	[Changelog] - New function `*QueriesClient.Delete(context.Context, string, string, string, *QueriesClientDeleteOptions) (QueriesClientDeleteResponse, error)`
    info	[Changelog] - New function `*QueriesClient.Get(context.Context, string, string, string, *QueriesClientGetOptions) (QueriesClientGetResponse, error)`
    info	[Changelog] - New function `*QueriesClient.NewListPager(string, string, *QueriesClientListOptions) *runtime.Pager[QueriesClientListResponse]`
    info	[Changelog] - New function `*QueriesClient.Put(context.Context, string, string, string, LogAnalyticsQueryPackQuery, *QueriesClientPutOptions) (QueriesClientPutResponse, error)`
    info	[Changelog] - New function `*QueriesClient.NewSearchPager(string, string, LogAnalyticsQueryPackQuerySearchProperties, *QueriesClientSearchOptions) *runtime.Pager[QueriesClientSearchResponse]`
    info	[Changelog] - New function `*QueriesClient.Update(context.Context, string, string, string, LogAnalyticsQueryPackQuery, *QueriesClientUpdateOptions) (QueriesClientUpdateResponse, error)`
    info	[Changelog] - New function `NewQueryPacksClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QueryPacksClient, error)`
    info	[Changelog] - New function `*QueryPacksClient.CreateOrUpdate(context.Context, string, string, LogAnalyticsQueryPack, *QueryPacksClientCreateOrUpdateOptions) (QueryPacksClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.CreateOrUpdateWithoutName(context.Context, string, LogAnalyticsQueryPack, *QueryPacksClientCreateOrUpdateWithoutNameOptions) (QueryPacksClientCreateOrUpdateWithoutNameResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.Delete(context.Context, string, string, *QueryPacksClientDeleteOptions) (QueryPacksClientDeleteResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.Get(context.Context, string, string, *QueryPacksClientGetOptions) (QueryPacksClientGetResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.NewListByResourceGroupPager(string, *QueryPacksClientListByResourceGroupOptions) *runtime.Pager[QueryPacksClientListByResourceGroupResponse]`
    info	[Changelog] - New function `*QueryPacksClient.NewListPager(*QueryPacksClientListOptions) *runtime.Pager[QueryPacksClientListResponse]`
    info	[Changelog] - New function `*QueryPacksClient.UpdateTags(context.Context, string, string, TagsResource, *QueryPacksClientUpdateTagsOptions) (QueryPacksClientUpdateTagsResponse, error)`
    info	[Changelog] - New function `*TablesClient.CancelSearch(context.Context, string, string, string, *TablesClientCancelSearchOptions) (TablesClientCancelSearchResponse, error)`
    info	[Changelog] - New function `*TablesClient.BeginCreateOrUpdate(context.Context, string, string, string, Table, *TablesClientBeginCreateOrUpdateOptions) (*runtime.Poller[TablesClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*TablesClient.BeginDelete(context.Context, string, string, string, *TablesClientBeginDeleteOptions) (*runtime.Poller[TablesClientDeleteResponse], error)`
    info	[Changelog] - New function `*TablesClient.Migrate(context.Context, string, string, string, *TablesClientMigrateOptions) (TablesClientMigrateResponse, error)`
    info	[Changelog] - New function `*WorkspacesClient.GetNSP(context.Context, string, string, string, *WorkspacesClientGetNSPOptions) (WorkspacesClientGetNSPResponse, error)`
    info	[Changelog] - New function `*WorkspacesClient.NewListNSPPager(string, string, *WorkspacesClientListNSPOptions) *runtime.Pager[WorkspacesClientListNSPResponse]`
    info	[Changelog] - New function `*WorkspacesClient.BeginReconcileNSP(context.Context, string, string, string, *WorkspacesClientBeginReconcileNSPOptions) (*runtime.Poller[WorkspacesClientReconcileNSPResponse], error)`
    info	[Changelog] - New struct `AccessRule`
    info	[Changelog] - New struct `AccessRuleProperties`
    info	[Changelog] - New struct `AccessRulePropertiesSubscriptionsItem`
    info	[Changelog] - New struct `AzureResourceProperties`
    info	[Changelog] - New struct `Column`
    info	[Changelog] - New struct `LogAnalyticsQueryPack`
    info	[Changelog] - New struct `LogAnalyticsQueryPackListResult`
    info	[Changelog] - New struct `LogAnalyticsQueryPackProperties`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQuery`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQueryListResult`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQueryProperties`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQueryPropertiesRelated`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQuerySearchProperties`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQuerySearchPropertiesRelated`
    info	[Changelog] - New struct `ManagedServiceIdentity`
    info	[Changelog] - New struct `NetworkSecurityPerimeter`
    info	[Changelog] - New struct `NetworkSecurityPerimeterConfiguration`
    info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationListResult`
    info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationProperties`
    info	[Changelog] - New struct `NetworkSecurityProfile`
    info	[Changelog] - New struct `ProvisioningIssue`
    info	[Changelog] - New struct `ProvisioningIssueProperties`
    info	[Changelog] - New struct `QueryPacksResource`
    info	[Changelog] - New struct `ResourceAssociation`
    info	[Changelog] - New struct `RestoredLogs`
    info	[Changelog] - New struct `ResultStatistics`
    info	[Changelog] - New struct `Schema`
    info	[Changelog] - New struct `SearchResults`
    info	[Changelog] - New struct `SystemData`
    info	[Changelog] - New struct `SystemDataAutoGenerated`
    info	[Changelog] - New struct `TagsResource`
    info	[Changelog] - New struct `UserAssignedIdentity`
    info	[Changelog] - New field `SystemData` in struct `Table`
    info	[Changelog] - New field `ArchiveRetentionInDays`, `LastPlanModifiedDate`, `Plan`, `ProvisioningState`, `RestoredLogs`, `ResultStatistics`, `RetentionInDaysAsDefault`, `Schema`, `SearchResults`, `TotalRetentionInDays`, `TotalRetentionInDaysAsDefault` in struct `TableProperties`
    info	[Changelog] - New field `Identity`, `SystemData` in struct `Workspace`
    info	[Changelog] - New field `UnifiedSentinelBillingOnly` in struct `WorkspaceFeatures`
    info	[Changelog] - New field `Identity` in struct `WorkspacePatch`
    info	[Changelog] - New field `DefaultDataCollectionRuleResourceID` in struct `WorkspaceProperties`
    info	[Changelog]
    info	[Changelog] Total 3 breaking change(s), 176 additive change(s).
    Present SDK breaking changes suppressions
    Operation `*TablesClient.Update` has been changed to LRO, use `*TablesClient.BeginUpdate` instead.
    Type of `Cluster.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    Type of `ClusterPatch.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 2a809539d15a4e69fd6c2c6b83fde59006344535. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-loganalytics [Preview SDK Changes] Breaking Change Detected
    • azure-mgmt-loganalytics-7.0.0b1.zip
    • azure_mgmt_loganalytics-7.0.0b1-py3-none-any.whl
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation TablesOperations.begin_create_or_update
    info	[Changelog]   - Added operation TablesOperations.begin_delete
    info	[Changelog]   - Added operation TablesOperations.cancel_search
    info	[Changelog]   - Added operation TablesOperations.migrate
    info	[Changelog]   - Added operation WorkspacesOperations.begin_reconcile_nsp
    info	[Changelog]   - Added operation WorkspacesOperations.get_nsp
    info	[Changelog]   - Added operation WorkspacesOperations.list_nsp
    info	[Changelog]   - Added operation group QueriesOperations
    info	[Changelog]   - Added operation group QueryPacksOperations
    info	[Changelog]   - Model Table has a new parameter archive_retention_in_days
    info	[Changelog]   - Model Table has a new parameter last_plan_modified_date
    info	[Changelog]   - Model Table has a new parameter plan
    info	[Changelog]   - Model Table has a new parameter provisioning_state
    info	[Changelog]   - Model Table has a new parameter restored_logs
    info	[Changelog]   - Model Table has a new parameter result_statistics
    info	[Changelog]   - Model Table has a new parameter retention_in_days_as_default
    info	[Changelog]   - Model Table has a new parameter schema
    info	[Changelog]   - Model Table has a new parameter search_results
    info	[Changelog]   - Model Table has a new parameter system_data
    info	[Changelog]   - Model Table has a new parameter total_retention_in_days
    info	[Changelog]   - Model Table has a new parameter total_retention_in_days_as_default
    info	[Changelog]   - Model Workspace has a new parameter default_data_collection_rule_resource_id
    info	[Changelog]   - Model Workspace has a new parameter etag
    info	[Changelog]   - Model Workspace has a new parameter identity
    info	[Changelog]   - Model Workspace has a new parameter system_data
    info	[Changelog]   - Model WorkspaceFeatures has a new parameter unified_sentinel_billing_only
    info	[Changelog]   - Model WorkspacePatch has a new parameter default_data_collection_rule_resource_id
    info	[Changelog]   - Model WorkspacePatch has a new parameter identity
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model Table no longer has parameter is_troubleshoot_enabled
    info	[Changelog]   - Model Table no longer has parameter is_troubleshooting_allowed
    info	[Changelog]   - Model Table no longer has parameter last_troubleshoot_date
    info	[Changelog]   - Model Workspace no longer has parameter e_tag
    info	[Changelog]   - Removed operation TablesOperations.create
    info	[Changelog]   - Renamed operation TablesOperations.update to TablesOperations.begin_update
    Present SDK breaking changes suppressions
    Model Table no longer has parameter is_troubleshoot_enabled
    Model Table no longer has parameter is_troubleshooting_allowed
    Model Table no longer has parameter last_troubleshoot_date
    Model Workspace no longer has parameter e_tag
    Removed operation TablesOperations.create
    Renamed operation TablesOperations.update to TablesOperations.begin_update
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 2a809539d15a4e69fd6c2c6b83fde59006344535. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-operationalinsights [Preview SDK Changes] Breaking Change Detected
    • azure-arm-operationalinsights-10.0.0.tgz
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation Workspaces.beginReconcileNSP
    info	[Changelog]   - Added operation Workspaces.beginReconcileNSPAndWait
    info	[Changelog]   - Added operation Workspaces.getNSP
    info	[Changelog]   - Added operation Workspaces.listNSP
    info	[Changelog]   - Added Interface AccessRule
    info	[Changelog]   - Added Interface AccessRuleProperties
    info	[Changelog]   - Added Interface AccessRulePropertiesSubscriptionsItem
    info	[Changelog]   - Added Interface ManagedServiceIdentity
    info	[Changelog]   - Added Interface NetworkSecurityPerimeter
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfiguration
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationListResult
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationProperties
    info	[Changelog]   - Added Interface NetworkSecurityProfile
    info	[Changelog]   - Added Interface ProvisioningIssue
    info	[Changelog]   - Added Interface ProvisioningIssueProperties
    info	[Changelog]   - Added Interface ResourceAssociation
    info	[Changelog]   - Added Interface UserAssignedIdentity
    info	[Changelog]   - Added Interface WorkspacesGetNSPOptionalParams
    info	[Changelog]   - Added Interface WorkspacesListNSPNextOptionalParams
    info	[Changelog]   - Added Interface WorkspacesListNSPOptionalParams
    info	[Changelog]   - Added Interface WorkspacesReconcileNSPHeaders
    info	[Changelog]   - Added Interface WorkspacesReconcileNSPOptionalParams
    info	[Changelog]   - Added Type Alias AccessRuleDirection
    info	[Changelog]   - Added Type Alias IssueType
    info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
    info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationProvisioningState
    info	[Changelog]   - Added Type Alias ResourceAssociationAccessMode
    info	[Changelog]   - Added Type Alias Severity
    info	[Changelog]   - Added Type Alias WorkspacesGetNSPResponse
    info	[Changelog]   - Added Type Alias WorkspacesListNSPNextResponse
    info	[Changelog]   - Added Type Alias WorkspacesListNSPResponse
    info	[Changelog]   - Added Type Alias WorkspacesReconcileNSPResponse
    info	[Changelog]   - Interface WorkspaceFeatures has a new optional parameter unifiedSentinelBillingOnly
    info	[Changelog]   - Added Enum KnownAccessRuleDirection
    info	[Changelog]   - Added Enum KnownIssueType
    info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
    info	[Changelog]   - Added Enum KnownNetworkSecurityPerimeterConfigurationProvisioningState
    info	[Changelog]   - Added Enum KnownResourceAssociationAccessMode
    info	[Changelog]   - Added Enum KnownSeverity
    info	[Changelog]   - Enum KnownProvisioningStateEnum has a new value Deleting
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Type of parameter systemData of interface AzureResourceProperties is changed from SystemData to SystemDataAutoGenerated
    info	[Changelog]   - Type of parameter identity of interface Cluster is changed from Identity to ManagedServiceIdentity
    info	[Changelog]   - Type of parameter identity of interface ClusterPatch is changed from Identity to ManagedServiceIdentity
    info	[Changelog]   - Type of parameter createdByType of interface SystemData is changed from IdentityType to CreatedByType
    info	[Changelog]   - Type of parameter lastModifiedByType of interface SystemData is changed from IdentityType to CreatedByType
    info	[Changelog]   - Type of parameter createdByType of interface SystemDataAutoGenerated is changed from CreatedByType to IdentityType
    info	[Changelog]   - Type of parameter lastModifiedByType of interface SystemDataAutoGenerated is changed from CreatedByType to IdentityType
    info	[Changelog]   - Type of parameter systemData of interface Table is changed from SystemDataAutoGenerated to SystemData
    info	[Changelog]   - Type of parameter systemData of interface Workspace is changed from SystemDataAutoGenerated to SystemData
    Present SDK breaking changes suppressions
    This package has no defined suppressions.
    Absent SDK breaking changes suppressions
    - Type of parameter createdByType of interface SystemData is changed from IdentityType to CreatedByType
    - Type of parameter createdByType of interface SystemDataAutoGenerated is changed from CreatedByType to IdentityType
    - Type of parameter identity of interface Cluster is changed from Identity to ManagedServiceIdentity
    - Type of parameter identity of interface ClusterPatch is changed from Identity to ManagedServiceIdentity
    - Type of parameter lastModifiedByType of interface SystemData is changed from IdentityType to CreatedByType
    - Type of parameter lastModifiedByType of interface SystemDataAutoGenerated is changed from CreatedByType to IdentityType
    - Type of parameter systemData of interface AzureResourceProperties is changed from SystemData to SystemDataAutoGenerated
    - Type of parameter systemData of interface Table is changed from SystemDataAutoGenerated to SystemData
    - Type of parameter systemData of interface Workspace is changed from SystemDataAutoGenerated to SystemData
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 2a809539d15a4e69fd6c2c6b83fde59006344535. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-loganalytics [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-loganalytics-1.1.0-beta.1-sources.jar
    • azure-resourcemanager-loganalytics-1.1.0-beta.1.jar
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from 2a809539d15a4e69fd6c2c6b83fde59006344535. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 2a809539d15a4e69fd6c2c6b83fde59006344535. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.operationalinsights.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
Learn more at aka.ms/azsdk/pr-arm-review.

@ramoka178 can we get a signoff on this PR?

akshitgoyal avatar May 01 '24 19:05 akshitgoyal

Just a heads up. I need to go through some careful review of these NSP definitions, I'm trying to figure out how to avoid many inconsistent definitions of these across services.

TimLovellSmith avatar May 02 '24 05:05 TimLovellSmith

@akshitgoyal I'm working on adding NetworkSecurityPerimeters to common types, as something like this is clearly urgently needed! Please help me review my PR.

https://github.com/Azure/azure-rest-api-specs/pull/28958

TimLovellSmith avatar May 02 '24 22:05 TimLovellSmith

@akshitgoyal I think you're nearly all good at this point, except for finalizing NSP type definitions and fixing SDK errors. I'm okay to sign off an ARM manifest PR at this point if you have one this is blocked on, because of the new types - no changes are needed in type names, that I can see. And we can keep working on the rest.

TimLovellSmith avatar May 03 '24 01:05 TimLovellSmith

sounds good! thanks @TimLovellSmith

akshitgoyal avatar May 03 '24 01:05 akshitgoyal

Marking this PR as need to refactor to refer to NSP definitions from

#28958

before merging.

To be clear the intent of this feedback is not to say that ARM is not signed off (ARM is signed off), nor is it to block manifest deployments (they should be unblocked)

@TimLovellSmith Can we receive the ArmSignOff label. I will refactor the code as soon as your PR is merged. Thanks!

akshitgoyal avatar May 06 '24 22:05 akshitgoyal

Hi @akshitgoyal, please fix the SDK azure-sdk-for-go CI issue

Alancere avatar May 11 '24 05:05 Alancere

@akshitgoyal Please refactor by using references to the [new] common types NSP definitions, letting me know of any blockers

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/networksecurityperimeter.json

TimLovellSmith avatar May 15 '24 16:05 TimLovellSmith

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]
️⌛ azure-sdk-for-net-track2 pending [Detail]
️⌛ azure-sdk-for-go pending [Detail]
️⌛ azure-sdk-for-python pending [Detail]
️⌛ azure-sdk-for-js pending [Detail]
️⌛ azure-powershell pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@akshitgoyal Please refactor by using references to the [new] common types NSP definitions, letting me know of any blockers

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/networksecurityperimeter.json

I have updated the PR with new common NSP types.

akshitgoyal avatar May 20 '24 23:05 akshitgoyal

@TimLovellSmith seems like NetworkSecurityPerimeterConfigurationNameParameter is causing issues. Can you take a look?

akshitgoyal avatar May 20 '24 23:05 akshitgoyal

@akshitgoyal You can add a suppression, or copy/paste the parameter definition and define your own pattern as reusing the parameter definition isn't critical, its just a convenience.

TimLovellSmith avatar May 21 '24 16:05 TimLovellSmith

@akshitgoyal Actually, is there a casing issue in your operation paths?

It should be ''/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/networkSecurityPerimeterConfigurations/{networkSecurityPerimeterConfigurationNameParameter}''

with a little 'n' at the start of the the parameter name (camel case), instead of a big 'N' (pascal case).

TimLovellSmith avatar May 21 '24 16:05 TimLovellSmith

/azp run

akshitgoyal avatar May 23 '24 22:05 akshitgoyal

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar May 23 '24 22:05 azure-pipelines[bot]

/azp run

TimLovellSmith avatar May 24 '24 17:05 TimLovellSmith

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar May 24 '24 17:05 azure-pipelines[bot]

Hi @akshitgoyal, please fix the SDK azure-sdk-for-go CI issue

Hey @Alancere, can you confirm if these CI issues are caused by current new changes? Can you help us resolve these?

akshitgoyal avatar May 30 '24 02:05 akshitgoyal

@TimLovellSmith I had to add parameter definition for NetworkSecurityPerimeterConfigurationNameParameter because the current common types don't have a "pattern" restriction and the CI checks are failing because of that. I think the common types definition needs to be updated to account for this. LintDiff will fail without that. For context, you can see this previous run: https://github.com/Azure/azure-rest-api-specs/pull/28733/checks?check_run_id=25582443380

if these changes look okay, can you approve them, so we can get this merged? Thanks

akshitgoyal avatar May 30 '24 02:05 akshitgoyal

Hi @akshitgoyal, please fix the SDK azure-sdk-for-go CI issue

Hey @Alancere, can you confirm if these CI issues are caused by current new changes? Can you help us resolve these?

The possible reason of Duplicate Schema is that different common-type versions are used. I find that package-2024-04 contains v2 and v5

For example: ErrorResponse

  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-08-01/OperationStatuses.json#L110
  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L68

Alancere avatar May 30 '24 03:05 Alancere

Hi @akshitgoyal, please fix the SDK azure-sdk-for-go CI issue

Hey @Alancere, can you confirm if these CI issues are caused by current new changes? Can you help us resolve these?

The possible reason of Duplicate Schema is that different common-type versions are used. I find that package-2024-04 contains v2 and v5

For example: ErrorResponse

  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-08-01/OperationStatuses.json#L110
  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L68

@Alancere Thanks for looking into this. My PR only makes changes to this file:

  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json

For resources like ProxyResource, ErrorDetail, etc, I cannot change the version for them because these new APIs and this PR doesn't reference them directly. Is it possible these were introduced because of a different PR in past? Is there a way to suppress these?

akshitgoyal avatar May 30 '24 03:05 akshitgoyal

Hi @akshitgoyal, please fix the SDK azure-sdk-for-go CI issue

Hey @Alancere, can you confirm if these CI issues are caused by current new changes? Can you help us resolve these?

The possible reason of Duplicate Schema is that different common-type versions are used. I find that package-2024-04 contains v2 and v5 For example: ErrorResponse

  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-08-01/OperationStatuses.json#L110
  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L68

@Alancere Thanks for looking into this. My PR only makes changes to this file:

  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json

For resources like ProxyResource, ErrorDetail, etc, I cannot change the version for them because these new APIs and this PR doesn't reference them directly. Is it possible these were introduced because of a different PR in past? Is there a way to suppress these?

Some are indirectly referenced, and it is recommended to unify the common-type version

Alancere avatar May 30 '24 03:05 Alancere

Hi @akshitgoyal, please fix the SDK azure-sdk-for-go CI issue

Hey @Alancere, can you confirm if these CI issues are caused by current new changes? Can you help us resolve these?

The possible reason of Duplicate Schema is that different common-type versions are used. I find that package-2024-04 contains v2 and v5 For example: ErrorResponse

  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-08-01/OperationStatuses.json#L110
  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json#L68

@Alancere Thanks for looking into this. My PR only makes changes to this file:

  • https://github.com/Azure/azure-rest-api-specs/blob/akshitgoyal/microsoft-operationinsights-nsp/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2021-10-01/Workspaces_NetworkSecurityPerimeter_API.json

For resources like ProxyResource, ErrorDetail, etc, I cannot change the version for them because these new APIs and this PR doesn't reference them directly. Is it possible these were introduced because of a different PR in past? Is there a way to suppress these?

Some are indirectly referenced, and it is recommended to unify the common-type version

@Alancere I have fixed most of them. However, for Resource and ProxyResource, these are referenced in ../../../../../common-types/resource-management/v5/networksecurityperimeter.json. networksecurityperimeter.json is only available in v5 and is necessary for this PR.

akshitgoyal avatar May 30 '24 05:05 akshitgoyal

@akshitgoyal , you will need to copy the models you referenced from networksecurityperimeter.json to your own swagger then update the Resource and ProxyResource reference from V2 common types if you cannot unify other version swaggers to reference V5 types.

raych1 avatar May 30 '24 07:05 raych1