Tim Lovell-Smith

Results 377 comments of Tim Lovell-Smith

There are many LintDiff errors, can you address more?

> "post": { just wondering, why was this API originally a POST as opposed to get? --- Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:196 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)

> "post": { Any special reason the verb is POST? Like read permissions being too permissive? Or you don't want to return a typical resource response body? Or secrets in...

> yes its just new version, no changes. We probably could have signed it off sooner if we realized, sorry for the delay!

@bojunehsu Are you ready to approve this PR?

@Juliehzl Very sorry to revisit an already approved PR, but I think we need to move towards making better use of common-types for private links, for maintainability reasons. Can you...

>I do not want to use common type because we have different values for some properties. Please merge it asap. We are urgent to release before build. I'm sorry but...

@ramoka178 want to mark this PR approved based on your review or does it need further review?

Do I see rightly that you're reviewing, at the same time, both a preview, and a non preview version, for the same exact month/version string? That sounds potentially quite confusing...

I'm seeing errors from a circular reference issue, I think that might be making it hard to validate this properly. Can we remove any circular references between json, such as...