Tim Lovell-Smith
Tim Lovell-Smith
> "Invalid", Consider documenting what customers are supposed to do about 'invalid' if they see it --- Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/preview/2024-05-15-preview/cosmos-db.json:10948 in d8a5483. [](commit_id = d8a5483047acff55177b06714438916b41c3211a, deletion_comment = False)
> "description": "Indicates the previous capacity mode of the account before successful transition.", interesting pattern! I'm a little curious about what before successful transition means in practice. Like whether it...
> }, For sake of codegen/maintainability you probably shouldn't define CapacityMode enum inline twice, instead you should make it a top level definition and reference it in two places -...
> "capacityModeTransitionBeginTimestamp": { Friendlier names derived from naming guidelines I'm aware of might be 'capacityModeTransitionBeganAt' 'capacityModeTransitionCompletedAt' 'capacityModeTransitionLastSucceededAt' ...but do we really have to prefix them all with capacityMode? Maybe not,...
Given we don't yet seem to have a proper network security perimeter definitions common types thing to use, I've manually diffed your definitions with another RPs to look for possible...
PS, FWIW storage RP swagger seems to think the NSP reference's location mutability should be read/create-only. I guess not every RP is the same - maybe, but you might want...
@vandit15 @pjohari-ms I'm working on adding NetworkSecurityPerimeters to common types, as something like this is clearly urgently needed! Please help me review my PR. https://github.com/Azure/azure-rest-api-specs/pull/28958
I have a lingering worry that some of the avocado errors might matter (e.g. missing a link to an example could stop it showing in docs, or perhaps impact model...
@pjohari-ms update, hopefully this is unblocked for refactor real soon. The adding NSP common-types PR should be merge-ready now, it should just need the checks to come back alive and...