Tim Lovell-Smith
Tim Lovell-Smith
> "description": "Identity to use for Key Vault Reference authentication.", I don't see this property in the examples in this PR BTW? --- In reply to: [1432561416](https://github.com/Azure/azure-rest-api-specs/pull/22159#issuecomment-1432561416) [](http://example.com/codeflow?ancestors=1432561416,1382665064,1382665064) --- Refers...
This one looks like you're declaring the Location header incorrectly per openapi >❌ unacceptable kind of an object to dump [object Error] | "role":"Model Validation","url":"https://github.com/Azure/azure-rest-api-specs/blob/e7f921b92fbc7c9aff11ee68d60a25f21809809c/specification/monitor/resource-manager/Microsoft.Insights/preview/2023-06-01-preview/privateLinkScopes_API.json"
There seem to be some new linter errors show up now (either because of changes or because some linter issues got fixed): ❌ XmsEnumValidation | The enum types should have...
This avocado warning sounds like its caused by an accidental oversight? >The example JSON file is not referenced from the swagger file. readme: [specification/monitor/resource-manager/readme.md](https://github.com/Azure/azure-rest-api-specs/blob/f8a06f888090de1374326ddc2925aad65cdaed3a/specification/monitor/resource-manager/readme.md) json: [preview/2023-06-01-preview/examples/PrivateLinkScopedResourceUpdatePlatformMetrics.json](https://github.com/Azure/azure-rest-api-specs/blob/f8a06f888090de1374326ddc2925aad65cdaed3a/specification/monitor/resource-manager/Microsoft.Insights/preview/2023-06-01-preview/examples/PrivateLinkScopedResourceUpdatePlatformMetrics.json)
> I see there are still ModelValidation issues around the casing for the enums. Please advise on how to make my enums case-insensitive - otherwise, validation issues should be resolved...
For Semantic I think there are also maybe one or two places where you need to fix ``` "readonly": "true", ``` to ``` "readonly": true, ``` ?
The changes look good to me overall but there are Linter errors you must address. ❌ XmsEnumValidation | The enum types should have x-ms-enum type extension set with appropriate options.Location: ...
/azp run
/pr RequestMerge