Tim Lovell-Smith
Tim Lovell-Smith
> "operationId": "BackupUsageSummariesCRR_List", Using this CRR abbreviation everywhere doesn't really seem good for readability of the doc. I also am finding it surprising in the context of the resource URI...
> "/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrJob": { I guess unfortunately 'CRR' ship has maybe already sailed. :( I do still think its an unfortunate appearance of Azure jargon in the REST API though. :(...
> }, I think its supposed to include a final operation response declaration, like 204 if there's no response content? Or 200 if there's a final response content after you...
> "$ref": "#/parameters/ApiVersion" Consider removing your definitions of these common parameters and redirecting to commontypes types.json instead #Resolved --- Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)
> "type": "string" could add `"format": "arm-id"` if its not breaking, which I'm unclear on (it seems nonbreaking on the wire at least) --- Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:2490 in d9dcaa9. [](commit_id...
> "$ref": "#/parameters/ApiVersion" Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter --- In reply to: [1977490589](https://github.com/Azure/azure-rest-api-specs/pull/27915#issuecomment-1977490589) [](http://example.com/codeflow?ancestors=1977490589) --- Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id =...
> "$ref": "#/parameters/ApiVersion" Its not really required for my signoff though. --- In reply to: [1979473884](https://github.com/Azure/azure-rest-api-specs/pull/27915#issuecomment-1979473884) [](http://example.com/codeflow?ancestors=1979473884,1977490589) --- Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)
> "$ref": "#/parameters/SubscriptionId" Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter #Resolved --- Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:264 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)
> "$ref": "#/parameters/AzureRegion" Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter #Resolved --- Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:261 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)
> "format": "arm-id" does it make sense to use [https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details](https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details) also? --- Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:2494 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)