azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Cancel Cross Region Restore Operation in API - 2023-12-15

Open asmaskar opened this issue 1 year ago • 35 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you, you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

asmaskar avatar Feb 26 '24 10:02 asmaskar

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 424 Errors, 381 Warnings failed [Detail]
Compared specs (v0.10.7) new version base version
bms.json 2023-12-15(0c576d6) 2023-08-01(main)
bms.json 2023-12-15(0c576d6) 2022-09-30-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 24 items are listed, please refer to log for more details.

Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L21:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L164:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L209:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L254:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L299:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L460:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L517:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.RecoveryServices/operations' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L577:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupconfig/vaultconfig' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L608:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupEncryptionConfigs/backupResourceEncryptionConfig' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L757:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L851:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}/operationsStatus/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1023:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/operationStatus/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1082:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/prepareDataMove' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1133:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/operationResults/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1188:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/triggerDataMove' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1242:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1297:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/operationResults/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1520:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1599:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}/restore' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1749:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1844:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies/{policyName}' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L1906:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies/{policyName}/operationResults/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L2095:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupJobs' removed or restructured?
Old: Microsoft.RecoveryServices/stable/2023-08-01/bms.json#L2154:5


The following breaking changes are detected by comparison with the latest preview version:

Only 24 items are listed, please refer to log for more details.

Rule Message
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L21:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L164:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L209:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L254:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L299:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L460:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L517:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.RecoveryServices/operations' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L577:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupconfig/vaultconfig' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L608:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupEncryptionConfigs/backupResourceEncryptionConfig' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L757:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L851:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}/operationsStatus/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1023:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/operationStatus/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1082:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/prepareDataMove' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1133:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/operationResults/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1188:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/triggerDataMove' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1242:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1297:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/operationResults/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1520:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1599:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}/restore' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1749:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1844:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies/{policyName}' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1906:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies/{policyName}/operationResults/{operationId}' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L2092:5
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupJobs' removed or restructured?
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L2151:5
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 47 Errors, 97 Warnings failed [Detail]
Compared specs (v2.2.0) new version base version
package-passivestamp-2023-12-15 package-passivestamp-2023-12-15(0c576d6) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 24 items are listed, please refer to log for more details.

Rule Message Related RPC [For API reviewers]
OperationsAPIImplementation Operations API must be implemented for 'Microsoft.RecoveryServices'.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L21
RPC-Uri-V1-05
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L62
PathForTrackedResourceTypes The path must be under a subscription and resource group for tracked resource types.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L87
RPC-Put-V1-01, RPC-Get-V1-11
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L88
RPC-Get-V1-13
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L118
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L138
RPC-Async-V1-11, RPC-Async-V1-14
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L171
RPC-Async-V1-07
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L247
RPC-Async-V1-11, RPC-Async-V1-14
ParametersInPost $filter is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L313
RPC-Post-V1-05
ParametersInPost $skipToken is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L313
RPC-Post-V1-05
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L402
RPC-Async-V1-07
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L466
RPC-Uri-V1-05
ResourceNameRestriction The resource name parameter 'fabricName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L466
RPC-Uri-V1-05
ResourceNameRestriction The resource name parameter 'containerName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L466
RPC-Uri-V1-05
ResourceNameRestriction The resource name parameter 'protectedItemName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L466
RPC-Uri-V1-05
PostResponseCodes Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L467
RPC-Async-V1-11, RPC-Async-V1-14
NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L534
EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L552
RPC-Put-V1-02
PathForNestedResource The path for nested resource doest not meet the valid resource pattern. There is one exception for extension resources with fully qualified path and the author can go ahead and suppress the error(look at https://github.com/Azure/azure-openapi-validator/blob/main/docs/path-for-nested-resource.md#pathfornestedresource for more details)
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L552
RPC-Uri-V1-06
PathForTrackedResourceTypes The path must be under a subscription and resource group for tracked resource types.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L552
RPC-Put-V1-01, RPC-Get-V1-11
PutGetPatchResponseSchema /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L552
RPC-Put-V1-12
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L552
RPC-Uri-V1-05
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L553
RPC-Get-V1-13


The following errors/warnings exist before current PR submission:

Only 24 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L772
ResourceNameRestriction The resource name parameter 'fabricName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L772
ResourceNameRestriction The resource name parameter 'containerName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L772
ResourceNameRestriction The resource name parameter 'protectedItemName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L772
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1134
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1291
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1301
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1387
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1387
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1405
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1412
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1593
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1766
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1784
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1902
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1936
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1946
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L1956
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L2033
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L2051
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L2082
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L2101
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L2152
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L2194
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
Rule Message
MULTIPLE_DEFAULT_TAGS The readme file has more than one default tag.
readme: specification/recoveryservicesbackup/resource-manager/readme.md
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from c28ef97284a672dd3d9cf9cec8cb21249c49a0ad. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.RecoveryServicesBackup [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from c28ef97284a672dd3d9cf9cec8cb21249c49a0ad. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] Average Speed   Time    Time     Time  Current
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  42217      0 --:--:-- --:--:-- --:--:-- 42217
    cmderr	[init.sh]  notice
    cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[init.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[init.sh] npm notice
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-recoveryservicesbackup [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from c28ef97284a672dd3d9cf9cec8cb21249c49a0ad. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `IaasVMSnapshotConsistencyType` with values `IaasVMSnapshotConsistencyTypeOnlyCrashConsistent`
    info	[Changelog] - New field `SnapshotConsistencyType` in struct `AzureIaaSVMProtectionPolicy`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from c28ef97284a672dd3d9cf9cec8cb21249c49a0ad. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-recoveryservicesbackup [View full logs]  [Preview SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added Type Alias IaasVMSnapshotConsistencyType
    info	[Changelog]   - Interface AzureIaaSVMProtectionPolicy has a new optional parameter snapshotConsistencyType
    info	[Changelog]   - Added Enum KnownIaasVMSnapshotConsistencyType
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from c28ef97284a672dd3d9cf9cec8cb21249c49a0ad. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️recoveryservicesbackup [View full logs]  [Preview Schema Changes]
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning [Logs] Generate from c28ef97284a672dd3d9cf9cec8cb21249c49a0ad. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.recoveryservicesbackup.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@ms-zhenhua Can you please check the PR now. the Lint Diff would fail as we have 2 versions. This was reviewed and discussed in the breaking change meeting

asmaskar avatar Mar 01 '24 18:03 asmaskar

    "operationId": "BackupUsageSummariesCRR_List",

Using this CRR abbreviation everywhere doesn't really seem good for readability of the doc.

I also am finding it surprising in the context of the resource URI and the description of the operation, that the abbreviation appears here #WontFix


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:27 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

TimLovellSmith avatar Mar 04 '24 21:03 TimLovellSmith

"/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrJob": {

I guess unfortunately 'CRR' ship has maybe already sailed. :(

I do still think its an unfortunate appearance of Azure jargon in the REST API though. :(

Has it shipped as a public API doc already? #Resolved


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:195 in d9dcaa9. [](commit_id = d9dcaa92db1812bacf9d6b4991bbebd6cd77f504, deletion_comment = False)

TimLovellSmith avatar Mar 04 '24 21:03 TimLovellSmith

    },

I think its supposed to include a final operation response declaration, like 204 if there's no response content? Or 200 if there's a final response content after you finish polling on the Location header. #Resolved


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:291 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

TimLovellSmith avatar Mar 04 '24 21:03 TimLovellSmith

        "$ref": "#/parameters/ApiVersion"

Consider removing your definitions of these common parameters and redirecting to commontypes types.json instead #Resolved


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

TimLovellSmith avatar Mar 04 '24 21:03 TimLovellSmith

      "type": "string"

could add "format": "arm-id" if its not breaking, which I'm unclear on (it seems nonbreaking on the wire at least)


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:2490 in d9dcaa9. [](commit_id = d9dcaa92db1812bacf9d6b4991bbebd6cd77f504, deletion_comment = False)

TimLovellSmith avatar Mar 04 '24 21:03 TimLovellSmith

    "operationId": "BackupUsageSummariesCRR_List",

Using this CRR abbreviation everywhere doesn't really seem good for readability of the doc.

I also am finding it surprising in the context of the resource URI and the description of the operation, that the abbreviation appears here

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:27 in ab6f027. [](commit_id = ab6f027, deletion_comment = False)

This is an existing API and we have not made any changes here. It would not be possible to fix it now

asmaskar avatar Mar 05 '24 05:03 asmaskar

"/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrJob": {

I guess unfortunately 'CRR' ship has maybe already sailed. :(

I do still think its an unfortunate appearance of Azure jargon in the REST API though. :(

Has it shipped as a public API doc already?

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:195 in d9dcaa9. [](commit_id = d9dcaa9, deletion_comment = False)

Yes, unfortunately the ship has sailed a long time back and this PR is just a minor renovation

asmaskar avatar Mar 05 '24 05:03 asmaskar

      "type": "string"

could add "format": "arm-id" if its not breaking, which I'm unclear on (it seems nonbreaking on the wire at least)

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:2490 in d9dcaa9. [](commit_id = d9dcaa9, deletion_comment = False)

Added this

asmaskar avatar Mar 05 '24 05:03 asmaskar

        "$ref": "#/parameters/ApiVersion"

Consider removing your definitions of these common parameters and redirecting to commontypes types.json instead

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027, deletion_comment = False)

Done the needful

asmaskar avatar Mar 05 '24 05:03 asmaskar

    },

I think its supposed to include a final operation response declaration, like 204 if there's no response content? Or 200 if there's a final response content after you finish polling on the Location header.

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:291 in ab6f027. [](commit_id = ab6f027, deletion_comment = False)

Added 200 as recommended

asmaskar avatar Mar 05 '24 05:03 asmaskar

        "$ref": "#/parameters/ApiVersion"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter


In reply to: 1977490589


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

TimLovellSmith avatar Mar 05 '24 19:03 TimLovellSmith

        "$ref": "#/parameters/ApiVersion"

Its not really required for my signoff though.


In reply to: 1979473884


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

TimLovellSmith avatar Mar 05 '24 19:03 TimLovellSmith

        "$ref": "#/parameters/SubscriptionId"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter #Resolved


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:264 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)

TimLovellSmith avatar Mar 05 '24 19:03 TimLovellSmith

        "$ref": "#/parameters/AzureRegion"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter #Resolved


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:261 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)

TimLovellSmith avatar Mar 05 '24 19:03 TimLovellSmith

      "format": "arm-id"

does it make sense to use https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details also?


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:2494 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)

TimLovellSmith avatar Mar 05 '24 19:03 TimLovellSmith

There are many LintDiff errors, can you address more?

TimLovellSmith avatar Mar 05 '24 19:03 TimLovellSmith

  "post": {

just wondering, why was this API originally a POST as opposed to get?


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:196 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)

TimLovellSmith avatar Mar 05 '24 19:03 TimLovellSmith

  "post": {

just wondering, why was this API originally a POST as opposed to get?

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:196 in 291d4c8. [](commit_id = 291d4c8, deletion_comment = False)

Only to enable LAC on source vault, since GET does not have a body :(

pratikjoshi14 avatar Mar 06 '24 03:03 pratikjoshi14

        "$ref": "#/parameters/ApiVersion"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter

In reply to: 1977490589

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027, deletion_comment = False)

Fixed this

asmaskar avatar Mar 06 '24 05:03 asmaskar

There are many LintDiff errors, can you address more?

I have addressed the ones for the ordering of parameters and also for using common types.. The others are related to the already existing APIs and I dont think i should make changes in the existing APIs. The reason being this is a special scenario for swagger for the cross region restore operation

asmaskar avatar Mar 06 '24 05:03 asmaskar

      "format": "arm-id"

does it make sense to use https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details also?

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:2494 in 291d4c8. [](commit_id = 291d4c8, deletion_comment = False)

Keeping this as arm-id and not adding the scope here

asmaskar avatar Mar 06 '24 05:03 asmaskar

        "$ref": "#/parameters/AzureRegion"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:261 in 291d4c8. [](commit_id = 291d4c8, deletion_comment = False)

updated

asmaskar avatar Mar 06 '24 05:03 asmaskar

  "post": {

Any special reason the verb is POST? Like read permissions being too permissive? Or you don't want to return a typical resource response body? Or secrets in the response?

It looks like otherwise you could maybe have gone with 'GET' since its 'listing job resources'.


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:304 in aacf11a. [](commit_id = aacf11a194beb1f092805e86a91e6fca36222e00, deletion_comment = False)

TimLovellSmith avatar Mar 06 '24 21:03 TimLovellSmith