Tim Lovell-Smith
Tim Lovell-Smith
> "tags": { Tags aren't normally there on proxyResource? --- Refers to: specification/netapp/resource-manager/Microsoft.NetApp/stable/2022-09-01/netapp.json:7738 in 01b0f4a. [](commit_id = 01b0f4ae1c678e620dd498a79cf41066689d75df, deletion_comment = False)
> }, Instead of defining your own resource class with required top level properties, 'id', 'type', 'name', and 'location' and 'tags' (for TrackedResource) its recommended to inherit from ProxyResource or...
> "$ref": "#/definitions/netAppAccountPatch" If you use the right x-ms-mutability and readOnly attributes, you can potentially reuse the same schema [here netAppAccount] for PUT, PATCH, and GET. --- In reply to:...
> }, You might not even need to define netAppAccountPatch if you can use netAppAccount instead and get the x-ms-mutability / readonly bits right --- In reply to: [1320658456](https://github.com/Azure/azure-rest-api-specs/pull/21606#issuecomment-1320658456) [](http://example.com/codeflow?ancestors=1320658456)...
> "UserAssignedIdentity": { Instead of defining your own managedIdentity or userAssignedIdentity class, I highly recommend finding one to use by $ref under common-types such as [https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management](https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management) --- In reply to:...
> }, This looks a lot like ManagedServiceIdentity from v5/managedidentity.json... can you ref that? [https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v5/managedidentity.json#L50](https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v5/managedidentity.json#L50) --- In reply to: [1320662725](https://github.com/Azure/azure-rest-api-specs/pull/21606#issuecomment-1320662725) [](http://example.com/codeflow?ancestors=1320662725) --- Refers to: specification/netapp/resource-manager/Microsoft.NetApp/stable/2022-09-01/netapp.json:4740 in 01b0f4a. [](commit_id = 01b0f4ae1c678e620dd498a79cf41066689d75df,...
> ], You can probably remove this - I think this is implied by inheriting from TrackedResoruce --- In reply to: [1320663061](https://github.com/Azure/azure-rest-api-specs/pull/21606#issuecomment-1320663061) [](http://example.com/codeflow?ancestors=1320663061) --- Refers to: specification/netapp/resource-manager/Microsoft.NetApp/stable/2022-09-01/netapp.json:4678 in 01b0f4a. [](commit_id...
> }, The OperationListResult type is defined correctly in commontypes types.json. It is recommended to reference and reuse the common definition instead of declaring your own. [Otherwise it is frequently...
Please give some thought to the refactoring suggestions. They may be the fastest way to resolve some linter errors, and if you get breaking changes by refactoring to a common-types...
@audunn >Referencing from TrackedResource for Accounts_Update makes location a requred parameter that is not requred today, is that acceptable for patch? That sounds like a little modeling glitch with regard...