Tim Lovell-Smith

@utkarshjain1508 A call sounds like a good idea; just because it is leveraging an external system doesn't necessarily mean you shouldn't use REST verbs. Was there some other reason?

@xiaoxuqi-ms any idea what is up with the apiDocPreview task? I've seen it failing in a lot of recent PRs.

Adding back 'ArmChangesRequested' as I didn't see responses or fixes for all comments.

> "responses": { put should also return 201 for created, unless this is a proxy resource that can't be created. --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:3634 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment...

> "$ref": "#/definitions/CloudError" Error responses - use common types There are definitions of error responses and details in commontypes types.json that you can use instead of declaring your own. See...

> "description": "Gets or sets the exclude resource types property. This property sets the resource types to be excluded during restore.", e.g. what values are OK? --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:4450...

> "description": "Gets or sets the PV Restore Mode property. This property sets whether volumes needs to be restored.", expand acronym --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:6389 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d,...

> "description": "Gets or sets the LabelSelectors property. This property sets the resource with such label selectors to be included during restore.", This boilerplate isn't very useful as documentation. Try...

> "type": "string" consider '"format": "arm-id"' and [https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details](https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details) --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7299 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

> "lastUpdatedTime": { readonly should be true --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7308 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)