Tim Lovell-Smith

> "ResourceGuardProxyBaseResource": { Should some of these base types like ResourceGuardProxyBaseResource be declaring a required discriminator property? --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7316 in 112258d. [](commit_id = 112258dc6685908bd6afcf606a42f405a76aa713, deletion_comment = False)

> "DppResource": { Refactor for consistency/reviewability Can this be replaced and you could instead inherit allOf common-types's ProxyResource? Or smaller refactor Can you declare DppResource as inheriting allOf common-types' ProxyResource?...

> "DppBaseTrackedResource": { Refactor for consistency/reviewability Can this be replaced and you could instead inherit allOf common-types's TrackedResource? Or smaller refactor Can you declare DppResource as inheriting allOf common-types' TrackedResource?...

> "DppIdentityDetails": { Refactor if basically nonbreaking UserAssignedIdentity, ManagedIdentity - use common types Instead of defining your own managedIdentity or userAssignedIdentity class, I highly recommend finding one to use by...

> "InnerError": { Refactor away by using common types, if its basically nonbreaking: Error responses - use common types There are definitions of error responses and details in commontypes types.json...

> "OperationResource": { Refactor away by using common-types if its basically non-breaking (it should be) OperationListResult - use common types The OperationListResult type is defined correctly in commontypes types.json. It...

> }, ARM recommends enums over booleans as explained here : [https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html](https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html) Standard guidance is: replace boolean/switch properties with better enum A boolean will forever have two valid values (true...

> }, describe: what are the valid string values? --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7357 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

> "resourceToBeDeleted": { consider '"format": "arm-id"' and [https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details](https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details) --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7358 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

> "type": "string" consider '"format": "arm-id"' and [https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details](https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details) --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7359 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)