Tim Lovell-Smith

> } format: datetime? --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7370 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

> }, ARM recommends enums over booleans as explained here : [https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html](https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html) Standard guidance is: replace boolean/switch properties with better enum A boolean will forever have two valid values (true...

> "description": { Looks like readonly should be true based on examples --- Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7311 in 112258d. [](commit_id = 112258dc6685908bd6afcf606a42f405a76aa713, deletion_comment = False)

> "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ProxyResource" Consider updating to v3 ProxyResoruce which should already defines SystemData for you - or maybe even later versions, I haven't seen them used too much yet though,...

I'd suggest expanding the acronym BYOK to BringYourOwnKey (or whatever it is)

Hi @ashutoshsuman99, I think this draft PR is inactive for a very long time, and that mentat9 intended to close it but maybe only commented instead. I'm going to go...

> }, There are definitions of common parameters in commontypes types.json that you can use instead of declaring your own, like LocationParameter, which is useful for modeling locations/{locationName} in paths...

> }, There are definitions of common parameters in commontypes types.json that you can use by $ref instead of declaring your own, like SubscriptionIdParameter, OperationIdParameter, and ApiVersionParameter, See [https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L630](https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L630) ---...

> }, There are definitions of common parameters in commontypes types.json that you can use by $ref instead of declaring your own, like SubscriptionIdParameter, OperationIdParameter, and ApiVersionParameter, See [https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L630](https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L630) ---...

> }, Instead of defining your own resource class with required top level properties, 'id', 'type', 'name', and 'location' and 'tags' (for TrackedResource) its recommended to inherit from ProxyResource or...