Matt Corallo
Matt Corallo
I wouldn't call it orthogonal at all, its very much relevant to this PR :). If you really want to avoid it, sure, we can rename the methods here, but...
> We also currently support constructing non-LDK-specific blinded paths in our API, and it looks like that support would be removed since presumably we’d be making the BlindedPath struct private...
> So keep the BlindedPath type public and have 3 path types, then? Wait why does `BlindedPath` need to be public? I mean we can implement (de)serialization on `BlindedMessagePath` and...
We could have a `Blinded{Message,Payment}::from_raw` constructor that just takes the fields we need, no?
> I can make the type private for now in this PR if that sounds good. Sure, seems fine.
Needs rebase already :(
Needs rebase :(
Feel free to squash IMO.
> @TheBlueMatt note that going with this design will mean undoing a good chunk of the work in https://github.com/lightningdevkit/rust-lightning/pull/3664 to no longer keep the non-dust sources separate. Should be fine...
Right, but why? I guess now because there's many commitment txn we will no longer rely on the HTLCs to be sorted in commitment-tx-order and so now it doesn't matter...