Matt Corallo
Matt Corallo
I don't know if its worth spending a ton of time debating this, but there is a tradeoff here between code readability and formatting overhead. Indeed, formatting overhead sucks, but,...
I'm totally with you on overly-complex control flow in a number of places in the codebase - indeed, its a known problem and something that is being (very slowly) cleaned...
> the conclusion I draw from that however is that it is a sign to de-nest the control flow even more aggressively, and to split out any easily isolated blocks...
See-also https://github.com/rust-bitcoin/rust-bitcoin/pull/959 (maybe we let them go first, assuming it ever happens?) and the two rustfmt issues linked towards the top of this issue that i think are still blocking...
Sadly git's conflict detection is horrendous when indentation changes. It does a poor job of identifying which block you're conflicting with and has a tendency to suggest you're conflicting with...
If we want to include something in the lightningdevkit repo, we should probably do something smart, like actually picking target paths that we have less information on rather than just...
Sure, if you want. I think, to start, we'd like to have a single function which, given a target node to probe, picks a path. As an initial go, we...
This is relatively unsafe. Its something we could be open to with specific user demand, but for now we haven't seen any, so I don't think it makes sense.
Just to be clear here - some LSPs allow the user to have zero reserve, but do not themselves take zero reserve. The client side is doable in LDK, it's...
This is getting more important with the LSPS work, but its probably not gonna happen in the next three weeks.