Matt Corallo comments

Results 964 comments of


                                            Matt Corallo

Persist counterparty_claimable_outpoints out of channel_monitor

I think we're still missing handling of HTLC spends on counterparty commitments. `transactions_confirmed` calls `check_spend_holder_transaction` but also checks if a transaction spends an input which is in `counterparty_commitment_txn_on_chain` and calls...

Persist counterparty_claimable_outpoints out of channel_monitor

We could do it in a followup (ideally in the same release), but we should encrypt these objects with the single-hash of the commitment transaction - that means this data...

Create script file for easy local linting

LGTM, feel free to rebase + squash and lets land this.

Do not attempt to handle unicast channel_update in NetworkGraph

I'm not sure what we can practically do about this - the `NetGraphMsgHandler` doesn't have any ideas what channels are ours and what aren't. We can tweak the error message...

Do not attempt to handle unicast channel_update in NetworkGraph

We can now do this because there's a dont-forward bit in the update.

Update RGS stats for August 2024.

Yea, I think lets remove the processing times. Otherwise lgtm.

Update RGS stats for August 2024.

Any update here?

Update RGS stats for August 2024.

Cool, should this be un-draft-ed now?

Include invoice requests in async payment onions

Needs rebase.

Expose blinded paths' `advance_path_by_one`

Okay, this is incredibly confusing, two methods in different contexts with the same name and arguments? Can we please split `BlindedPath` into two types now?