Matt Corallo
Matt Corallo
Naming is hard :). I'm a bit meh on `floor_amount` because it doesn't mention the unit being floor'd to, which I think substantially improves readability of callsites.
> I believe it's soon enough after the method was first introduced that renaming it should not have big negative impact, if any. Its not in a release, so there's...
That would be good with me, or `amount_sats_floor` or any other permutation :)
Yea, will include this commit there, assuming we move forward with #1555.
> This PR returns a BlockTemplate interface which causes the node to hold on to the template and its block. > The goal is to be able to quickly send...
We also now see failure to build due to https://github.com/rust-lang/rust/issues/84738. Maybe its time to switch to stable (or stable-built-with-unstable-flags-enabled) now given the recent instability of nightly?
Correct me if I’m wrong, but that doesn’t seem to preclude the possibility of pinning nightly instead of upgrading regularly? If nightly were pinned and only updated more occasionally we...
Is it not possible to build the release tags without the release bit set - effectively using “stable” without needing to use only stable features? Years ago I was aware...
Kicking the can in the hopes we delete `update_fee` instead.
Honestly better off with shutdown v3 and to never do this.