rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Allow `update_fee` sending during shutdown negotiation

Open TheBlueMatt opened this issue 3 years ago • 2 comments

Currently if we've started shutdown we refuse to queue up update_fee messages, but we absolutely should, given they can be important if shutdown takes a while due to a stuck HTLC. Further, we may actually have an edge case where we send an update_fee as the very last thing in a channel - if there's an update_fee pending in the holding cell (and its the only thing in the holding cell) when we receive our peer's last RAA we may let the update_fee fly even though there are no remaining HTLCs, violating the BOLTs (cc https://github.com/lightning/bolts/pull/970).

TheBlueMatt avatar Jul 02 '22 18:07 TheBlueMatt

Kicking the can in the hopes we delete update_fee instead.

TheBlueMatt avatar Oct 11 '24 20:10 TheBlueMatt

Honestly better off with shutdown v3 and to never do this.

TheBlueMatt avatar Sep 02 '25 01:09 TheBlueMatt