Matt Corallo
Matt Corallo
No? The lines are still longer than 70 chars?
CI thinks there's still places that need updating to the new API (possibly needs rebase), other than that this LGTM.
CI is still failing, see the check_commits and fuzz jobs.
LGTM, but will need to wait for the next release.
1. Bleh, something still has to call these, which kinda feels like we'd end up with 3 anyway, 2. No way, we'd end up screwing up and leaking the existence...
> Note that for (4) we could combine the NodeIdLookup trait from (3) as an associated type on ChannelMessageHandler, which the new method would return. Then have the ChannelManager implementation...
> Which of the parts should live in ldk-node/ldk/payjoin/separate crate. This question is raised because while we doing this in LDK-node, maybe we could also enable other node implementations who...
Why not just run the payjoin protocol after `accept_channel` but before `funding_generated`/signing?
> If we want to open multiple channels from a single payjoin transaction I don't see why that changes things? You can just wait until all channels are ready for...
Right, that seems like it wouldn't require any LDK changes, I think, and generally be the same implementation complexity on the payjoin side, AFAICT - either way you have to...