Matt Corallo

Results 964 comments of Matt Corallo

May have been at least partially addressed by #2529?

Doesn't need to be release-blocking.

Its dumb this has taken this long, but can wait for 117.

Not every platform supports atomic u64s.

Maybe more generally put, we should expose a concrete idea of what we think we can realistically receive over a channel in `inbound_capacity`, rather than the total we can receive...

Turned out to be complicated and 116 has too much else going on.

Oops left this comment on the wrong issue. Anyway, we should do this, and while its *not* complicated, it doesn't have to happen in 116.

Also when we do this we need to de-dup the descriptors rather than erroring on dups.

I think we should actually not do this post-https://github.com/lightning/bolts/pull/1163, but leaving this open until we address the BOLT changes.