Matt Corallo
Matt Corallo
I'm still confused why it needs to happen this way. Here's what I had in mind: We're a node that wants to *send* payment(s) via payjoin, and in doing so...
Please make your commit message more descriptive, see https://cbea.ms/git-commit/ for some guidelines.
Closing as abandoned
> Previously, we would require our users to handle all events successfully inline or panic will trying to do so I believe our recommendation was always to simply loop trying...
> Could you clarify which flag you are referring to exactly? The `event_persist_notifier` flag. > as otherwise the entire run loop might busy-wait I think that's okay if the BP...
> I'm confused: wouldn't this only work for ChannelManager's event handler, not the others, i.e., ChainMonitor, OnionMessenger? Sure, they should all do a similar thing. > Hmm, I tend to...
> Coming back to this: Upon further inspection it seems we set result = NotifyOption::DoPersist in process_events_body whenever we have pending events anyways? So the event_persist_notifier should already get triggered?...
The `Make event handling fallible` commit itself doesn't build, so `check_commits` is failing.
Also https://github.com/lightningdevkit/rust-lightning/pull/3140#discussion_r1760132719 and https://github.com/lightningdevkit/rust-lightning/pull/3140#discussion_r1759425911
Awesome, thanks for writing this up. I do wonder to what extent we want to build something with multisig inside rust-lightning or even LDK itself vs letting VLS build it...