Allow for user-specified error message during force close channel

[Sharmalm]

This Pr solves issue #2840

[coderabbitai[bot]]

[!IMPORTANT]

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 98.24561% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.21%. Comparing base (ac9a2c8) to head (d17e759). Report is 41 commits behind head on main.

Files	Patch %	Lines
lightning/src/ln/channelmanager.rs	94.44%	2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2889      +/-   ##
==========================================
+ Coverage   89.42%   90.21%   +0.78%     
==========================================
  Files         117      118       +1     
  Lines       96290   104723    +8433     
  Branches    96290   104723    +8433     
==========================================
+ Hits        86109    94475    +8366     
- Misses       7962     8097     +135     
+ Partials     2219     2151      -68     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[Sharmalm]

I have updated the PR, Please review. :)

[Sharmalm]

I have updated the above changes in my Pr.

[Sharmalm]

Gentle reminder for the review.

[Sharmalm]

If every thing looks good, I will squash it.

[Sharmalm]

Please proofread your commit before you push, don't rely on reviewers.

Understood, I'll keep in mind in future.

[Sharmalm]

I have Proofread my commits, and i think it is fulfilling the objectives of issue, if not I'll update the PR accordingly :)

[TheBlueMatt]

Basically LGTM! Please squash the commit history so that each commit stands on its own and compiles+passes tests and no later commits are fixing/cleaning up things from previous commits (in this PR I think that probably means just one commit). Also please line-wrap the commit message(s) to 70 chars. Finally, note that your diff has some end-of-line whitespace in a few places. A local git show should highlight them for you so you can remove them.

[Sharmalm]

Ok, Thankyou @TheBlueMatt for the guidance to complete this PR.

[TheBlueMatt]

Please line-wrap your commit message text.

[Sharmalm]

Please line-wrap your commit message text.

Is it fine now?

[TheBlueMatt]

No? The lines are still longer than 70 chars?

[Sharmalm]

Done.

[TheBlueMatt]

CI thinks there's still places that need updating to the new API (possibly needs rebase), other than that this LGTM.

[Sharmalm]

CI is also done. Thanks :)

[TheBlueMatt]

CI is still failing, see the check_commits and fuzz jobs.

[Sharmalm]

Sorry about that, I missed it.

[TheBlueMatt]

LGTM, but will need to wait for the next release.