rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Improve channel config parameter consistency

Open tnull opened this issue 2 years ago • 2 comments

It's kind of confusing that we have different lower bounds for channel parameters, such as capacity.

For example, while ChannelHandshakeLimits::min_funding_satoshis defaults to 0 and hence indicates that there is no lower limit, ChannelHandshakeConfig::their_channel_reserve_proportional_millionths effectively sets a 1000sat lower-bound on the channel capacity.

We should improve the consistency of these parameters as well as their documentation.

tnull avatar Feb 28 '23 17:02 tnull

Doesn't need to be release-blocking.

TheBlueMatt avatar Apr 07 '23 05:04 TheBlueMatt

Its dumb this has taken this long, but can wait for 117.

TheBlueMatt avatar Jul 02 '23 20:07 TheBlueMatt