rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Be More Conservative on Sending Shutdown

Open TheBlueMatt opened this issue 3 years ago • 3 comments

cc https://github.com/lightning/bolts/issues/964 but we need to update our shutdown sending/handling - we should accept a shutdown even if there's pending updates, and we also need to consider update_fail/update_fail_malformed and update_fee as "pending updates".

TheBlueMatt avatar Feb 28 '22 19:02 TheBlueMatt

If this is still relevant I'd be happy to run with it, unless there is some other deeper context I'd need to be aware of / cannot easily discover in LDK's handling.

dunxen avatar May 02 '22 16:05 dunxen

I'd let this one sit for a bit. There continues to be some debate in the BOLTs as to the correct direction here, with multiple alternative PRs going different directions.

TheBlueMatt avatar May 02 '22 20:05 TheBlueMatt

May have been at least partially addressed by #2529?

TheBlueMatt avatar May 06 '24 02:05 TheBlueMatt