Matt Corallo
Matt Corallo
It'd be nice to have a rationale section that discusses potential uses for this (and arguably more importantly, cases where this should *not* be used). eg if you're doing some...
One potential use-case we could describe here would be where a sender is a regulated financial institution sending to a pubkey it knows is another regulated financial institution, where they...
Ugh, this slipped off my radar. > In that case, can't they make a regular lightning payment without sender auth and send the additional info along with the payment hash...
A bit weird we have a BLIP reserving a value for a BOLT PR - do we want to include like a timeout on this reservation - "just for testing,...
This is not on nightly, but rather using `RUSTC_BOOTSTRAP=1`
Fair enough, I have a hack right now that forces cargo to fetch an old compiler_builtins (and cc), deletes the new ones out of the cargo repository, then builds with...
Also, please include at least a bit of detail in the commit messages.
Feel free to squash and we can land this IMO. We should open an issue and block the next release on the followup.
The only change from @tnull's previous ACK is the following, so gonna merge: ```diff diff --git a/lightning/src/chain/channelmonitor.rs b/lightning/src/chain/channelmonitor.rs index 0dda18629..7a6551bab 100644 --- a/lightning/src/chain/channelmonitor.rs +++ b/lightning/src/chain/channelmonitor.rs @@ -3232,4 +3232,3 @@ impl...
This isn't blocked on anything anymore, right? Is there anything you want early feedback on here?