Matt Corallo

Results 964 comments of Matt Corallo

Addressed @jkczyz's point and squashed: ```diff $ git diff-tree -U1 fadb26875 21aebd2d7 diff --git a/lightning-background-processor/src/lib.rs b/lightning-background-processor/src/lib.rs index 6b7cd5b05..a17f514a5 100644 --- a/lightning-background-processor/src/lib.rs +++ b/lightning-background-processor/src/lib.rs @@ -57,5 +57,2 @@ use std::time::Instant; -#[cfg(not(feature...

:facepalm: ```diff $ git diff-tree -U1 21aebd2d eedceeb3 diff --git a/lightning-background-processor/src/lib.rs b/lightning-background-processor/src/lib.rs index a17f514a5..a5d56c459 100644 --- a/lightning-background-processor/src/lib.rs +++ b/lightning-background-processor/src/lib.rs @@ -693,3 +693,3 @@ where let fetch_time = &fetch_time; - async...

lol ffs merged without noticing there were still fixup commits...oh well, they were just doc fixes so not really a big deal.

Would be cool if this somehow disabled the min-feerate checks entirely.

Because this uses the existing `FeeEstimator` `MinAllowedAnchorChannelRemoteFee` and `MinAllowedNonAnchorChannelRemoteFee` values, setting them to 0/253 will disable this entirely including the existing force-closes from peers sending us low values. Are you...

Oops, the fuzz failure was not unrelated. The `full_stack_target` fuzzer has a sanity check to ensure we get notified if the fuzz format changes implying our existing corpus is less...

Rebased to address conflicts with upstream and squashed the fixup.