Matt Corallo
Matt Corallo
We shouldn't be changing the announced limit, because the announced limit is just reflective of what we can actually send. Instead, we need to change the in-flight limit that we...
Right, okay, so the current patch here removes the 90% limit for private channels, which I guess is fine (but I think we always ignore anyway when we're the other...
Sadly needs a simple rebase.
I personally like it more, thanks. I'll let @tnull chime in but I think this is basically there.
Thanks, that's helpful. So it looks like you multiply the base penalty by 200, the based penalty amount multiplier by 100, and all 4 liquidity penalties by 15. Those are...
This basically LGTM I think. Only outstanding items is https://github.com/lightningdevkit/rust-lightning/pull/3016#discussion_r1781207030 (or some other way of removing the `delegate` dependency when not building with `_test_utils`) and https://github.com/lightningdevkit/rust-lightning/pull/3016#discussion_r1578011334 Either way feel free...
> I am making delegate optional for non-dev builds. is this what you wanted, or did you also want it to be optional for dev? Ugh, sorry I missed this,...
Hmm, harder to get it to read quite as great but its still quite doable - https://play.rust-lang.org/?version=stable&mode=release&edition=2021&gist=77fc7ed667016785cb760200f33585a1
Also CI is very sad.
Ugh sorry this needs rebase after #3604. Should clean a few things up nicely though.