Minimize reads to counterparty_claimable_outpoints

[G8XSU]

• [ ] Minimize current set of non-current/previous_commitment reads to counterparty_claimable_outpoints by re-using existing get calls and refactors

As part of #3049

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.76%. Comparing base (1890e80) to head (1690c66). Report is 45 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   89.82%   89.76%   -0.07%     
==========================================
  Files         116      116              
  Lines       96466    96466              
  Branches    96466    96466              
==========================================
- Hits        86655    86591      -64     
- Misses       7264     7311      +47     
- Partials     2547     2564      +17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[G8XSU]

Now this PR should be ready for review. But even so, there might be further changes as i get into further tasks for https://github.com/lightningdevkit/rust-lightning/issues/3049 So it is not ready for merging.

[G8XSU]

This PR is ready for review and merging. Any further refactor changes, we can do in follow-up.

[TheBlueMatt]

The only change from @tnull's previous ACK is the following, so gonna merge:

diff --git a/lightning/src/chain/channelmonitor.rs b/lightning/src/chain/channelmonitor.rs
index 0dda18629..7a6551bab 100644
--- a/lightning/src/chain/channelmonitor.rs
+++ b/lightning/src/chain/channelmonitor.rs
@@ -3232,4 +3232,3 @@ impl<Signer: EcdsaChannelSigner> ChannelMonitorImpl<Signer> {
 	/// height > height + CLTV_SHARED_CLAIM_BUFFER. In any case, will install monitoring for
-	/// HTLC-Success/HTLC-Timeout transactions. This function should only be called when claimable HTLC
-	/// data is available in `counterparty_claimable_outpoints`.
+	/// HTLC-Success/HTLC-Timeout transactions.
 	///