Matt Corallo

Results 964 comments of Matt Corallo

Right, that's what I meant by "no failure reason", sorry it was unclear. My point is that if you don't upgrade for two years suffering from degraded route selection performance...

I'm kinda confused why a fee_insufficient failure is > 256 bytes? There's a ton of headroom above existing error messages to play with.

Two notes: a) why connect them at all? I don't see how they're related or even touch similar parts of code. b) That doesn't explain the issue - if you...

> It does require more code, at least in our implementation, and it requires expanding the test matrix. Huh, that's surprising. At least on our end (and lnd) the only...

Hmm, all of those are gossip-based messages, you should have something with the OpenChannel/AcceptChannel a ways after that, maybe grep for it?

Hmm, kinda annoyed we didn't figure out the failure to fall back to a different channel type thing, but I guess not enough to actually go test and figure out...

No there should be more than enough logs (at trace level we log all messages as sent and received), it just wasn't reproduced (and I forgot about this issue until...

No strong opinion on AGPL/GPL/MIT on the rights, AGPL seems like a totally fine choice for this project, but in general I strongly prefer open source licenses with an explicit...

As of https://github.com/rust-lang/rust/pull/79998, in order to fix the use-case of linking C code (which passes structs by value) with Rust code, the wasm32-wasi target now has an ABI incompatibility with...