Starlight220
Starlight220
According to the API docs on the parallel C++ method, the maximum pulse length is 0.0016 seconds. https://github.com/wpilibsuite/allwpilib/blob/faa29d596c9a01447a36fd5eaa18e8ad28434ad4/wpilibc/src/main/native/include/frc/DigitalOutput.h#L78-L86 Perhaps this is worthy of adding a range check and warning?
So that false info in the API docs should be fixed.
On second thought, maybe this is simply a discoverability issue and can be resolved by renaming the class to `DigitalSim` or `DigitalInputOutputSim` (the latter might be too verbose)? Splitting the...
Shouldn't `setGoal` call `setSetpoint` on the backing controller object? I don't remember if that's in the current impl, but it should be. Changing `CommandScheduler`'s run loop order sounds like a...
I want to make sure that it's clear that `interruptible` (or whatever we call it) is relevant only in the event of a new command being scheduled that shares requirements...
There are some changes (`.gitignore`, gradle) that I don't see how they are related here. Is there a reason to capture by value and not by reference? I'm not sure...
@Daltz333 isn't this solved by Inspector? Or could be fixed by one of #3069 / #3672? I'm honestly not sure if it'll be that significant of a workflow improvement compared...
To be honest, I think that title popups might be more comfortable than settings windows. Is there a reason to switch, beyond "that's the way it's supposed to be done"?...
- I don't think `functional` is a good idea, there are too many parameters for the verbosity decrease to be significant. - `repeat` and `endless` should be decorators and not...
As for your first point, I agree that `RunEndCommand` would be useful, though I have seen usages of `StartEndCommand` (mostly for toggle operations, but there were other cases). As for...