Starlight220

Results 348 comments of Starlight220

Should C++ get a generic `CreateCommand` method to sugar the `make_unique` call? (#4303)

The question is how to add that automagically to user-defined command classes? Does C++ inheritance support static members? Or perhaps we can mimic the [Kotlin pseudoconstructor idiom](https://medium.com/@belokon.roman/kotlin-pseudo-constructors-217ef05a45d6), overloading the `()`...

So now simple differential drive arcade driving will need to invert both `xSpeed` and `zRotation` as opposed to only `xSpeed`? I just want to confirm. Whatever the case is, examples...

> KilloughDrive was removed since no one uses it. Does usage data confirm this? @Kevin-OConnor

Same goes for Java with `Collections.min(Collection, Comparator)`.

Needs some design decisions about command properties (requirements, runsWhenDisabled, etc) that can't be checked without polling the supplier (which defies the point).

Found the issue: C++ `WrapperCommand` wasn't forwarding the `GetRequirements()` call. Thanks, everyone who helped.