allwpilib
allwpilib copied to clipboard
wpilibsuite
Sendable richness
Improves telemetry richness for several commonly-used, troubleshooting-prone Sendables. Also adds some more state getters/setters to classes that should have had them.
Are you planning to add this data to the widgets in the dashboards?
If I have time for it. Getting it into NetworkTables is the priority for now.
I don't think that changing the kCos to kG should be a part of this PR, as it's not related. It should be it's own PR. This PR is huge already and seems risky to merge mid-season.
I don't think that changing the kCos to kG should be a part of this PR, as it's not related. It should be it's own PR. This PR is huge already and seems risky to merge mid-season.
It's a param rename; it doesn't break anything.
If you see anything in particular in the PR that you think is risky, please point it out, but I've been putting a lot of work into addressing concerns...
I don't think that changing the kCos to kG should be a part of this PR, as it's not related. It should be it's own PR. This PR is huge already and seems risky to merge mid-season.
It's a param rename. It breaks nothing.
I agree, that's why it shouldn't be a part of this PR. It's everything else I was commentating on.
I don't think that changing the kCos to kG should be a part of this PR, as it's not related. It should be it's own PR. This PR is huge already and seems risky to merge mid-season.
It's a param rename. It breaks nothing.
I agree, that's why it shouldn't be a part of this PR. It's everything else I was commentating on.
It'd be a bit of a pain to do it separately from this PR, but I suppose I can spin off another. I do think this is mergeable, though.
There are some changes (.gitignore, gradle) that I don't see how they are related here.
Is there a reason to capture by value and not by reference? I'm not sure about the semantics.
This publishes many properties that I'm not sure are useful and I'm a bit apprehensive about them clogging up network traffic. Especially since LiveWindow auto-population is still a thing. It might be better to publish only commonly-used properties, and the few teams using niche properties can publish those easily enough.
Is there anything that needs to be completed before this gets merged?
i'd have to rebase it, resolve conflicts, and then we'd have to agree on scope?
This PR has a lot of conflicts and the author has abandoned it. If someone wants to resurrect it and finish it, they can do so in a new PR.
