Starlight220

Results 351 comments of Starlight220

How coupled are these changes? I think it'd be better to split it into different PRs.

> the smart dashboard type should be unique for each controller I'm not a fan of this; it adds a ton of new types that dashboards need to implement specially...

Do we want to do this as part of the larger renames in 2027?

This would cause isFinished to return true before the command started, too -- which is worse behavior than the current, imo. Calling isFinished only has defined behavior between initialize and...

I will do the java part now.

Should I already remove the deprecated PID parts?

Usages (such as Trigger) need to be updated

I think that `whileTrueLowPriority` is a bit too complex/niche and could be solved by a `Subsystem.idle` trigger that would be more useful to more use cases. A few years ago...

What new counter classes? I think the wrong allwpilib PR is linked.

Either way I think too much stuff reaches into the scheduler statically to have swapping out the scheduler be clean. As for C, a separate type isn't needed -- CommandScheduler...