Starlight220 comments

Results 351 comments of


                                            Starlight220

Improve `Color#toString()`/`Color8Bit#toString()` in Java

The PR that closed this fixed the confusion, but doesn't deal with names for specialized colors.

Improve `Color#toString()`/`Color8Bit#toString()` in Java

I was thinking of adding a `string` constructor parameter that defaults to the RGB hex. That way it's cached for all objects, and not expensive at all.

Improve `Color#toString()`/`Color8Bit#toString()` in Java

Sounds like a good idea.

RobotPy aborts in nt::impl::EntryNotifierThread during interpreter shutdown when using SendableBuilder

Any update on this? If the problem isn't on the RobotPy side, do we know more specifically where the problem is on the WPILib side?

Discuss is we should run tests on deploy by default

`test`s would run on `deploy` if `deploy` depended on `build`. Since it doesn't, then tests would never run on deploy.

Discuss is we should run tests on deploy by default

Since many teams rarely simply `build` but usually only deploy, the tests will almost never be run if they don't run on deploy. On the other hand, running tests could...

Subsystems should support the same periodic and init methods as `IterativeRobotBase`

Expansion of #3442: > Setting a "safe/idle state" to subsystems is important, similar to `MotorController.stopMotor()`. This is especially important with control loops, it's easy to forget to `setpoint = 0`...

Switch away from NI interrupt manager to custom implementation

This doesn't have any user-facing changes, right?

Use IsSimulation() consistently

If the `isReal` naming is confusing with Romi etc, how about renaming it to `isRoboRIO`? --- I think it's much more convenient and clear to directly check what is wanted...

Use IsSimulation() consistently

I'll address these in the order of the table you posted: - Whether the code is deployed or ran on the compiling machine is easy to know at compile-time, and...