[1.20.5] Add data-driven brewing recipe system

[Minecraftschurli]

This PR replaces the in code brewing recipe system added by neoforge on top of the hardcoded vanilla one with a data-driven approach through the recipe system

[neoforged-pr-publishing[bot]]

• [x] Publish PR to GitHub Packages

Last commit published: ea43a9c4a1e21761a3732bfc927f3ff090d3d018.

PR Publishing

The artifacts published by this PR:

• :package: net.neoforged:neoforge:20.4.207-pr-476-datadriven-brewing

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #476' // https://github.com/neoforged/NeoForge/pull/476
        url 'https://prmaven.neoforged.net/NeoForge/pr476'
        content {
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr476.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr476
cd NeoForge-pr476
curl -L https://prmaven.neoforged.net/NeoForge/pr476/net/neoforged/neoforge/20.4.207-pr-476-datadriven-brewing/mdk-pr476.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[KnightMiner]

This has been brought up many times before. The concerns usually raised are some combination of server with Neo on one side and vanilla the other will have desyncs if datapacks add anything. The notable case I remember is Neo server and vanilla client as the brewing slot filters are controlled by the brewing registry

[Minecraftschurli]

1. The vanilla checking has not been implemented yet but is easily possible
2. We have a discussion going in discord here

[Shadows-of-Fire]

Given the recent changes to PotionBrewing in 1.20.5-pre1, we should dismiss this change and wait for vanilla to provide this functionality natively.

[TelepathicGrunt]

Do we want to close this PR and open a fresh one when 1.21.1 or later comes out? Mojang could make more changes

[Shadows-of-Fire]

Yeah, this isn't very feasible for us to do atm. Closing.