ninja-python-distributions icon indicating copy to clipboard operation
ninja-python-distributions copied to clipboard

Upgrade to Ninja 1.13.1

Open segevfiner opened this issue 5 months ago • 4 comments

Ninja 1.13.1 is available and it includes a new jobserver implementation so we probably don't even need a fork of Ninja anymore? (Unless the Kitware fork will pick up some new PR that we will want, e.g. Some missing jobserver functionality and so on). Might want to update this to the latest official Ninja?

segevfiner avatar Jul 10 '25 21:07 segevfiner

The fork is still needed c.f. #305 1.13.1 from kitware might be available at a later date (c.f. https://github.com/Kitware/ninja/pull/3#issuecomment-3146466038)

mayeut avatar Aug 02 '25 14:08 mayeut

TL;DR: The fork supports older versions of Make vs. the official jobserver implementation, which requires a very new version. Once we don't care about older versions of Make, the fork can be dropped.

henryiii avatar Aug 11 '25 14:08 henryiii

1.13.0 is out. Leaving this open since 1.13.1 is not available in the fork yet.

henryiii avatar Aug 11 '25 15:08 henryiii

FYI Ninja 1.13.0 is affected by https://github.com/ninja-build/ninja/issues/2616 which breaks various builds on Windows. I've had to unpin ninja in a few repositories to avoid the broken release and it looks like others have had to do the same. A more comprehensive testing and rollout plan would be appreciated, since debugging has caused substantial churn.

ScottTodd avatar Aug 15 '25 22:08 ScottTodd

Ninja has released version 1.13.1, which can be found at https://github.com/ninja-build/ninja/releases . Will it be helpful?

ooooo-create avatar Nov 18 '25 05:11 ooooo-create

The Kitware fork needs to be updated.

henryiii avatar Nov 18 '25 05:11 henryiii

The Kitware fork needs to be updated.

Thank you so much! I understand now.

ooooo-create avatar Nov 18 '25 05:11 ooooo-create