Sarah French
Sarah French
The original release note layout was correct according to our contribution guides for new resources/data sources: https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/#type-specific-guidelines-and-examples ~We'll need 2 entries due to the PR adding 2 data sources.~ I'll...
I just approved the tests to run. Also, please take a look at the CLA issue!
@SamanthaMathews I believe that the tests run automatically on push for Googlers who show on their profiles that they're a member of a Google-owned GitHub org (this is how our...
Ah, I believe you need to be a member of https://github.com/googlers
Further to [what I said above](https://github.com/GoogleCloudPlatform/magic-modules/pull/11576#issuecomment-2385583199) - membership of the googlers orgs needs to be public - take a look at: [go/terraform-contribution-guide#before-you-begin](http://goto.google.com/terraform-contribution-guide#before-you-begin)
Hi @SamanthaMathews, we can mark this PR as ready for review to work through the test failure, but first please address the failing CLA check.
@modular-magician reassign-reviewer
@SamanthaMathews Hi, thanks for opening a PR! Could you please [sign the CLA](https://github.com/GoogleCloudPlatform/magic-modules/pull/11569#issuecomment-2316195801) and I can get started reviewing
@modular-magician reassign-reviewer
Test is failing due to ``` default Cloud Build service account or user-specified service account does not have access to the bucket ``` This might be due to [changes in...