commit terraform-redis-tags1

[SamanthaMathews]

This PR is to add tags field to Redis Instance

release-note:enhancement

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[SarahFrench]

@SamanthaMathews Hi, thanks for opening a PR! Could you please sign the CLA and I can get started reviewing

[github-actions[bot]]

@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

Discussing with @SamanthaMathews offline about this PR and the go rewrite migration

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 92 insertions(+), 5 deletions(-)) google-beta provider: Diff ( 5 files changed, 92 insertions(+), 5 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_instance (13 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_instance" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 22 Passed tests: 21 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisInstance_tags

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccRedisInstance_tags[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[SarahFrench]

@modular-magician reassign-reviewer

[SamanthaMathews]

The contents of this code are entirely owned by Google LLC in accordance with the agreement between Google LLC and the third party submitting this code into Google's open source repository

[c2thorn]

Hi @SamanthaMathews These pull requests are old enough that I recommend simply opening new ones to get the latest changes. We've modified our CI significantly since October and merging this may break things.