magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Address downstream dependabot PR, fix `TestAccAppEngineFlexibleAppVersion_update`

Open SarahFrench opened this issue 1 year ago • 23 comments

See https://github.com/hashicorp/terraform-provider-google-beta/pull/7582/files

Release Note Template for Downstream PRs (will be copied)


SarahFrench avatar Jun 28 '24 16:06 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician avatar Jun 28 '24 16:06 modular-magician

Tests analytics

Total tests: 14 Passed tests: 12 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • appengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

modular-magician avatar Jun 28 '24 16:06 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log] TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jun 28 '24 17:06 modular-magician

Test is failing due to

default Cloud Build service account or user-specified service account does not have access to the bucket

This might be due to changes in the default provided permissions for the GAE default service account?

Either way I'm catching strays 😂

SarahFrench avatar Jun 28 '24 17:06 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 31 insertions(+), 1 deletion(-)) google-beta provider: Diff ( 3 files changed, 31 insertions(+), 1 deletion(-))

modular-magician avatar Jun 28 '24 17:06 modular-magician

Tests analytics

Total tests: 14 Passed tests: 12 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • appengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

modular-magician avatar Jun 28 '24 17:06 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log] TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jun 28 '24 17:06 modular-magician

Ah the IAM stuff I copied wasn't good- I'll update the tests to use a user-created service account next week

SarahFrench avatar Jun 28 '24 19:06 SarahFrench

I've got some changes I want to push but I'm being blocked by my patch branch being protected (??) so I cannot force push following a rebase. Might remake this PR from my personal fork if needed.

SarahFrench avatar Jul 01 '24 18:07 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 88 insertions(+), 24 deletions(-)) google-beta provider: Diff ( 3 files changed, 88 insertions(+), 24 deletions(-))

modular-magician avatar Jul 02 '24 11:07 modular-magician

Tests analytics

Total tests: 14 Passed tests: 12 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • appengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

modular-magician avatar Jul 02 '24 11:07 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log] TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jul 02 '24 11:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 88 insertions(+), 24 deletions(-)) google-beta provider: Diff ( 3 files changed, 88 insertions(+), 24 deletions(-))

modular-magician avatar Jul 02 '24 14:07 modular-magician

Tests analytics

Total tests: 14 Passed tests: 12 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • appengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

modular-magician avatar Jul 02 '24 14:07 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log] TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jul 02 '24 14:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 55 insertions(+), 19 deletions(-)) google-beta provider: Diff ( 3 files changed, 124 insertions(+), 31 deletions(-))

modular-magician avatar Aug 19 '24 14:08 modular-magician

Tests analytics

Total tests: 13 Passed tests: 11 Skipped tests: 2 Affected tests: 0

Click here to see the affected service packages
  • appengine

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician avatar Aug 19 '24 15:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 55 insertions(+), 19 deletions(-)) google-beta provider: Diff ( 3 files changed, 124 insertions(+), 32 deletions(-))

modular-magician avatar Aug 19 '24 17:08 modular-magician

Tests analytics

Total tests: 13 Passed tests: 11 Skipped tests: 1 Affected tests: 1

Click here to see the affected service packages
  • appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_update

Get to know how VCR tests work

modular-magician avatar Aug 19 '24 17:08 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Aug 19 '24 17:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 57 insertions(+), 20 deletions(-)) google-beta provider: Diff ( 3 files changed, 160 insertions(+), 37 deletions(-))

modular-magician avatar Aug 20 '24 18:08 modular-magician

Tests analytics

Total tests: 13 Passed tests: 11 Skipped tests: 1 Affected tests: 1

Click here to see the affected service packages
  • appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_update

Get to know how VCR tests work

modular-magician avatar Aug 20 '24 18:08 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Aug 20 '24 18:08 modular-magician