Sarah French

Results 293 comments of Sarah French

Hi @jazzlyn, thanks for raising this issue and showing a workaround for others who might have the same issue! I've found that the underlying cause is that the 2 APIs...

For the last commit I only noticed that running `make generate` reverted a typo fix because I looked through the diffs carefully... hopefully this PR will reduce similar errors going...

I did a quick PR to address this that didn't solve the underlying issue, so didn't close this issue

Hi @billyfoss - I'm having some trouble reproducing this issue, could you please post an example of how you're calling the [beta-private-cluster](https://registry.terraform.io/modules/terraform-google-modules/kubernetes-engine/google/latest/submodules/beta-private-cluster) module?

Hi @jbardin - I requested a review from you because you were the most recent person to edit CODEOWNERS and I didn't want my first PR into core to be...

Ah yeah of course, I hadn't noticed that. In that case I'll update my PR to have `gcs` owned by both @hashicorp/terraform-ecosystem-strategic (for documentation purposes) and @hashicorp/terraform-google, and will try...

This PR is paired with https://github.com/GoogleCloudPlatform/magic-modules/pull/6473 but I'm keeping them separate because: - This PR is specific to the `google_iam_policy` data source and has more code changes - The other...

Thanks! I'll save merging this until the other PR is ready, so they can be released at the same time. As for backwards-incompatibility issues with this PR, I don't think...

> google-beta/iam_compute_machine_image_generated_test.go:144:123: expected operand, found ',' Error from `terraform-provider-google-beta-test` check Corresponds to this template code ```erb ImportStateId: fmt.Sprintf(" %s", , , context["condition_title"]), ``` producing this Go code: ```go ImportStateId: fmt.Sprintf("projects/%s/global/machineImages/%s...

I don't think the existing acceptance tests for IAM `*_binding` and `*_member` resources (which this change touches) are relevant to the change in this PR. All those tests have conditions...