Sarah French

Results 293 comments of Sarah French

Initial acc tests for the SDK and PF provider code. These tests aren't final, as we're waiting for some more acc tests to be added to the code base and...

Latest commits address some of the test failures described in [this comment](https://github.com/GoogleCloudPlatform/magic-modules/pull/11903#issuecomment-2390938783).

Force pushed after a rebase to pull in the final acceptance tests related to provider configuration logic + some edits to Firebase acctests I made on main

Here I'm running acceptance tests to see which ones fail, similar to https://github.com/GoogleCloudPlatform/magic-modules/pull/11903#issuecomment-2390938783 above. TeamCity links: - [GA SDK tests](https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_PROVIDER/255598?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true) - [GA Framework tests](https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_FWPROVIDER/255599?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true) - [Beta SDK tests](https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_PROVIDER/255600?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true) - [Beta...

The last few commits are acting on my comments in https://github.com/GoogleCloudPlatform/magic-modules/pull/11903#issuecomment-2437457030 Edit: [0f85c17](https://github.com/GoogleCloudPlatform/magic-modules/pull/11903/commits/0f85c17165048b3dcf8adbac0f2e92cc70b3d504) was a correction to one of these commits

After the previous commits' changes to tests to address the discussion in https://github.com/GoogleCloudPlatform/magic-modules/pull/11903#issuecomment-2437457030 I've re-run acceptance tests in TeamCity: SDK tests - [GA](https://github.com/GoogleCloudPlatform/magic-modules/pull/11903#issuecomment-2437457030) 18/18 pass - [Beta](https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_PROVIDER/257288?focusLine=NaN&hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildDeploymentsSection=false) 18/18 pass Framework...

Also, today I did some manual testing to confirm that this PR fixes some authentication bugs that were introduced by muxing: https://github.com/hashicorp/terraform-provider-google/issues/16832#issuecomment-2441432304 That comment has information about how to reproduce...

Opened for review - I've stopped doing self-review and manual testing, so I'm waiting on review comments either about the code, testing or to coordinate merging the PR

>it looks like we've moved forward with solution 2 of keeping the same level of validation: [aca5d33 (#11903)](https://github.com/GoogleCloudPlatform/magic-modules/pull/11903/commits/aca5d333d80b76d263426269c6855d223a880182) correct? Yeah that's right, I figured it was nicer to avoid making...