Sarah French

Results 293 comments of Sarah French

For reference, these are the tests affected by this PR: - (new) `TestAccComputeImageIamPolicy_googleIamPolicyDataSource` - `TestAccProjectIamBinding_withCondition` - `TestAccOrganizationIamMembersAndBindings` - `testAccOrganizationIamBinding_condition` test case - `testAccOrganizationIamMember_condition` test case - `TestAccFolderIamMember_multiple` - `TestAccFolderIamMember_remove`

Hi @melinath ! Sorry to chase, but I wanted to get some feedback about how to test this change. I tried editing the IAM tests in a 'centralised' way by...

> FWIW I am able to get a diff in the beta provider by modifying iam_test_file.go.erb Ah I think I know what may have happened - when IAM conditions were...

I've encountered a possible bug with the plugin SDK, and the last commit was a version of the tests that triggers the bug Edit: But the tests have passed ok...

To help it stand out from the description above: I found this very similar issue (https://github.com/hashicorp/terraform-plugin-sdk/issues/531) that was closed in 2020.

The tests I've experienced failures with have passed in the the automated tests on PRs in the terraform-provider-google repo ([link to tests on the relevant PR here](https://github.com/GoogleCloudPlatform/magic-modules/pull/6473#issuecomment-1248468219)), which is interesting

Thanks for addressing this! In my case I must have been using a newer version of TF locally versus the version used in terraform-provider-google's automated tests. I'll revisit the affected...

Validation was added to `google_compute_network` in https://github.com/GoogleCloudPlatform/magic-modules/pull/6348, marking this issue as closed

Hi @SudharsaneSivamany - thank you for bringing this to our attention! So if I understand correctly, the issue is that unsetting `service_account` or `artifact_storage` in the `execution_configs` block doesn't cause...

Ah, sorry, I didn't realise that there was a 'runtime problem' if the user provides the details of Google-managed resources. Thank you for checking! The updates to required to fix...