Sam Wilson
Sam Wilson
Thank you for taking a look at this! I'll try to review this and merge it at some point. Is there a matching PR for EIPs? If not, don't worry...
> Hello hello. Can I please get a merge on this PR? To see my current review queue, take a look at [EIPs Insight](https://eipsinsight.com/boards).
I'm not sure this will have much of an effect unless we also add some kind of formatter, which I'm not opposed to.
Still some TODOs in the document.
Can't be merged until conflicts are resolved.
Would you mind updating [this](https://github.com/ethereum/EIPs/blob/ea55bb3f9e64d03737f7ac22b0b855e30af2abfd/config/eipw.toml#L146) and [this](https://github.com/ethereum/ERCs/blob/69d9ff62044ffd5edd41271e79ffe807b8bbb93d/config/eipw.toml#L137)? If so, we can get this merged.
Taking another look through this today. Thanks for addressing my comments so far. I did want to check in about my last point, however: > How necessary is all of...
Where would these references be used? It doesn't make much sense to link to an old EIP-1, since those rules aren't used any more.
Closing because of conflicts. Once those are resolved, feel free to open a new PR.
Please keep technical discussion on the forum: https://ethereum-magicians.org/t/erc-7828-chain-specific-addresses-using-ens/21930