Sam Wilson

Results 309 comments of Sam Wilson

What issue is this associated with?

Ah. For this one, you'll want to make a change somewhere around here: https://github.com/ethereum/eipw/blob/93266e615fcc32fef89d703aaad1357cbe229463/eipw-lint/src/lints/markdown/regex.rs#L136-L138 The easiest solution (and the one I'd recommend) is skipping the `self.check(...)` call if `link.url ==...

Yep! If you can add a test with an autolink to show that your change works as expected, that'd be great too.

You'll need to setup Rust, and use cargo (not npm.) See https://doc.rust-lang.org/book/ch01-00-getting-started.html

There is no test yet for this issue, so there's nothing to fail. A test might look something like: ```rust #[tokio::test] async fn excludes_autolink() { let src = r#"--- header:...

I think all that's left on this one is updating a few tests in `eipw-lint-js`. For example: https://github.com/ethereum/eipw/blob/97e667a6ec71aded1e26121058f310351cee0a3f/eipw-lint-js/tests/main.rs#L400 Thanks so much for your help!

Nothing has been decided about this one yet.

You cannot place links in an image alt text, at least as far as I know, so ignoring this lint for all image alt texts makes the most sense to...

This change cuts the running time of EELS' `stStaticCall - StaticcallToPrecompileFromCalledContract_d0g0v0_Berlin` test from 248.37s (it hit a timeout, don't know how long it actually runs for) to 5.72s, an improvement...

Closing because I'm _pretty sure_ this is an April fools joke.